From: Andrew Morton <akpm@osdl.org>
To: Manfred Spraul <manfred@colorfullife.com>
Cc: penberg@cs.helsinki.fi, linux-kernel@vger.kernel.org,
colpatch@us.ibm.com
Subject: Re: [PATCH 4/5] slab: extract slab order calculation to separate function
Date: Sat, 19 Nov 2005 09:33:10 -0800 [thread overview]
Message-ID: <20051119093310.281ffbc2.akpm@osdl.org> (raw)
In-Reply-To: <437F199C.9040505@colorfullife.com>
Manfred Spraul <manfred@colorfullife.com> wrote:
>
> >+ } else
> >+ left_over = calculate_slab_order(cachep, size, align, flags);
> >
> >
>
> I usually add braces in this case: If braces are necessary for either
> the if or the else-clause, then I add braces to both parts.
>
> Could be applied as is, or I could write a patch with both changes.
> Andrew - what do you prefer?
I normally add the braces in both legs of the `if' if one leg needs them.
But it looks crappy either way, so whatever.
next prev parent reply other threads:[~2005-11-19 17:33 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-18 17:20 [PATCH 1/5] slab: rename obj_reallen to obj_size Pekka Enberg
2005-11-18 17:20 ` [PATCH 2/5] slab: remove unused align parameter from alloc_percpu Pekka Enberg
2005-11-18 17:20 ` [PATCH 3/5] slab: extract slabinfo header printing to separate function Pekka Enberg
2005-11-18 17:20 ` [PATCH 4/5] slab: extract slab order calculation " Pekka Enberg
2005-11-18 17:20 ` [PATCH 5/5] slab: fix code formatting Pekka Enberg
2005-11-19 12:25 ` [PATCH 4/5] slab: extract slab order calculation to separate function Manfred Spraul
2005-11-19 17:33 ` Andrew Morton [this message]
2005-11-19 12:11 ` [PATCH 3/5] slab: extract slabinfo header printing " Manfred Spraul
2005-11-19 12:20 ` Pekka Enberg
2005-11-19 12:00 ` [PATCH 2/5] slab: remove unused align parameter from alloc_percpu Manfred Spraul
2005-11-19 11:57 ` [PATCH 1/5] slab: rename obj_reallen to obj_size Manfred Spraul
2005-11-19 12:04 ` Pekka Enberg
2005-11-19 12:34 ` Manfred Spraul
2005-11-19 12:37 ` Pekka Enberg
2005-11-19 12:17 ` Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051119093310.281ffbc2.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=colpatch@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=manfred@colorfullife.com \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.