All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Jackson <pj@sgi.com>
To: Rohit Seth <rohit.seth@intel.com>
Cc: akpm@osdl.org, clameter@engr.sgi.com, torvalds@osdl.org,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	steiner@sgi.com, nickpiggin@yahoo.com.au
Subject: Re: [PATCH]: Free pages from local pcp lists under tight memory conditions
Date: Wed, 23 Nov 2005 19:02:37 -0800	[thread overview]
Message-ID: <20051123190237.3ba62bf0.pj@sgi.com> (raw)
In-Reply-To: <1132779605.25086.69.camel@akash.sc.intel.com>

Rohit wrote:
> I thought Nick et.al came up with some of the constant values like batch
> size to tackle the page coloring issue specifically. 

I think this came about on a linux-ia64 thread started by Jack Steiner:

  http://www.gelato.unsw.edu.au/archives/linux-ia64/0504/13668.html
  Subject: per_cpu_pagesets degrades MPI performance
  From: Jack Steiner <steiner_at_sgi.com>
  Date: 2005-04-05 05:28:27

Jack reported that per_cpu_pagesets were degrading some MPI benchmarks due
to adverse page coloring.  Nick responded, recommending a non-power of two
batch size.  Jack found that this helped nicely.  This thread trails off,
but seems to be the origins of the 2**n-1 batch size in:

	mm/page_alloc.c:zone_batchsize()
	 * Clamp the batch to a 2^n - 1 value. Having a power ...
        batch = (1 << fls(batch + batch/2)) - 1;

I don't see here evidence that "per_cpu_pagelist is ... one single main
reason the coloring effect is drastically reduced in 2.6 (over 2.4)
based kernels."  Rather in this case anyway a batch size not a power of
two was apparently needed to keep per_cpu_pagesets from hurting
performance due to page coloring affects on some workloads.

-- 
                  I won't rest till it's the best ...
                  Programmer, Linux Scalability
                  Paul Jackson <pj@sgi.com> 1.925.600.0401

WARNING: multiple messages have this Message-ID (diff)
From: Paul Jackson <pj@sgi.com>
To: Rohit Seth <rohit.seth@intel.com>
Cc: akpm@osdl.org, clameter@engr.sgi.com, torvalds@osdl.org,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	steiner@sgi.com, nickpiggin@yahoo.com.au
Subject: Re: [PATCH]: Free pages from local pcp lists under tight memory conditions
Date: Wed, 23 Nov 2005 19:02:37 -0800	[thread overview]
Message-ID: <20051123190237.3ba62bf0.pj@sgi.com> (raw)
In-Reply-To: <1132779605.25086.69.camel@akash.sc.intel.com>

Rohit wrote:
> I thought Nick et.al came up with some of the constant values like batch
> size to tackle the page coloring issue specifically. 

I think this came about on a linux-ia64 thread started by Jack Steiner:

  http://www.gelato.unsw.edu.au/archives/linux-ia64/0504/13668.html
  Subject: per_cpu_pagesets degrades MPI performance
  From: Jack Steiner <steiner_at_sgi.com>
  Date: 2005-04-05 05:28:27

Jack reported that per_cpu_pagesets were degrading some MPI benchmarks due
to adverse page coloring.  Nick responded, recommending a non-power of two
batch size.  Jack found that this helped nicely.  This thread trails off,
but seems to be the origins of the 2**n-1 batch size in:

	mm/page_alloc.c:zone_batchsize()
	 * Clamp the batch to a 2^n - 1 value. Having a power ...
        batch = (1 << fls(batch + batch/2)) - 1;

I don't see here evidence that "per_cpu_pagelist is ... one single main
reason the coloring effect is drastically reduced in 2.6 (over 2.4)
based kernels."  Rather in this case anyway a batch size not a power of
two was apparently needed to keep per_cpu_pagesets from hurting
performance due to page coloring affects on some workloads.

-- 
                  I won't rest till it's the best ...
                  Programmer, Linux Scalability
                  Paul Jackson <pj@sgi.com> 1.925.600.0401

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2005-11-24  3:02 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-23  0:10 [PATCH]: Free pages from local pcp lists under tight memory conditions Rohit Seth
2005-11-23  0:10 ` Rohit Seth
2005-11-23  5:36 ` Andrew Morton
2005-11-23  5:36   ` Andrew Morton
2005-11-23  5:58   ` Andrew Morton
2005-11-23  5:58     ` Andrew Morton
2005-11-23 18:17     ` Rohit Seth
2005-11-23 18:17       ` Rohit Seth
2005-11-23  6:36   ` Christoph Lameter
2005-11-23  6:36     ` Christoph Lameter
2005-11-23  6:42   ` Christoph Lameter
2005-11-23  6:42     ` Christoph Lameter
2005-11-23 16:35     ` Linus Torvalds
2005-11-23 16:35       ` Linus Torvalds
2005-11-23 17:03       ` Christoph Lameter
2005-11-23 17:03         ` Christoph Lameter
2005-11-23 17:54   ` Rohit Seth
2005-11-23 17:54     ` Rohit Seth
2005-11-23 18:06     ` Mel Gorman
2005-11-23 18:06       ` Mel Gorman
2005-11-23 19:41       ` Rohit Seth
2005-11-23 19:41         ` Rohit Seth
2005-11-24  9:25         ` Mel Gorman
2005-11-24  9:25           ` Mel Gorman
2005-11-23 23:26       ` Rohit Seth
2005-11-23 23:26         ` Rohit Seth
2005-11-23 19:30 ` Christoph Lameter
2005-11-23 19:30   ` Christoph Lameter
2005-11-23 19:46   ` Rohit Seth
2005-11-23 19:46     ` Rohit Seth
2005-11-23 19:55     ` Andrew Morton
2005-11-23 19:55       ` Andrew Morton
2005-11-23 21:00       ` Rohit Seth
2005-11-23 21:00         ` Rohit Seth
2005-11-23 21:25         ` Christoph Lameter
2005-11-23 21:25           ` Christoph Lameter
2005-11-23 22:29           ` Rohit Seth
2005-11-23 22:29             ` Rohit Seth
2005-11-23 21:26         ` Andrew Morton
2005-11-23 21:26           ` Andrew Morton
2005-11-23 21:40           ` Rohit Seth
2005-11-23 21:40             ` Rohit Seth
2005-11-24  3:02         ` Paul Jackson [this message]
2005-11-24  3:02           ` Paul Jackson
2005-11-29 23:18           ` Rohit Seth
2005-11-29 23:18             ` Rohit Seth
2005-12-01 14:44             ` Paul Jackson
2005-12-01 14:44               ` Paul Jackson
2005-12-02  0:32               ` Nick Piggin
2005-12-02  0:32                 ` Nick Piggin
2005-11-23 22:01       ` Christoph Lameter
2005-11-23 22:01         ` Christoph Lameter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051123190237.3ba62bf0.pj@sgi.com \
    --to=pj@sgi.com \
    --cc=akpm@osdl.org \
    --cc=clameter@engr.sgi.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=nickpiggin@yahoo.com.au \
    --cc=rohit.seth@intel.com \
    --cc=steiner@sgi.com \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.