Re: [-mm patch] init/main.c: dummy mark_rodata_ro() should be static

[Adrian Bunk <bunk@stusta.de>]

On Wed, Nov 23, 2005 at 02:46:51PM -0800, Randy.Dunlap wrote:
> On Wed, 23 Nov 2005, Adrian Bunk wrote:
> 
> > Every inline dummy function should be static.
> 
> Please explain why it matters in this case.

We don't need an additional global copy of the function.

> > Signed-off-by: Adrian Bunk <bunk@stusta.de>
> >
> > --- linux-2.6.15-rc2-mm1-full/init/main.c.old	2005-11-23 16:50:45.000000000 +0100
> > +++ linux-2.6.15-rc2-mm1-full/init/main.c	2005-11-23 16:50:55.000000000 +0100
> > @@ -101,7 +101,7 @@
> >  static inline void acpi_early_init(void) { }
> >  #endif
> >  #ifndef CONFIG_DEBUG_RODATA
> > -inline void mark_rodata_ro(void) { }
> > +static inline void mark_rodata_ro(void) { }
> >  #endif
> >
> >  #ifdef CONFIG_TC
> 
> -- 
> ~Randy

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed