From: Adrian Bunk <bunk@stusta.de>
To: Andrew Morton <akpm@osdl.org>, Arjan van de Ven <arjan@infradead.org>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>
Subject: [-mm patch] dummy mark_rodata_ro() should be static
Date: Thu, 24 Nov 2005 06:14:05 +0100 [thread overview]
Message-ID: <20051124051405.GO3963@stusta.de> (raw)
In-Reply-To: <20051123223505.GF3963@stusta.de>
On Wed, Nov 23, 2005 at 11:35:05PM +0100, Adrian Bunk wrote:
> Every inline dummy function should be static.
>...
Sorry, the patch was incomplete.
Updated patch below.
cu
Adrian
<-- snip -->
Every inline dummy function should be static.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
include/asm-i386/cacheflush.h | 2 ++
include/asm-x86_64/cacheflush.h | 3 +++
init/main.c | 2 +-
3 files changed, 6 insertions(+), 1 deletion(-)
--- linux-2.6.15-rc2-mm1/include/asm-i386/cacheflush.h.old 2005-11-24 05:55:28.000000000 +0100
+++ linux-2.6.15-rc2-mm1/include/asm-i386/cacheflush.h 2005-11-24 06:09:24.000000000 +0100
@@ -31,6 +31,8 @@
void kernel_map_pages(struct page *page, int numpages, int enable);
#endif
+#ifdef CONFIG_DEBUG_RODATA
void mark_rodata_ro(void);
+#endif
#endif /* _I386_CACHEFLUSH_H */
--- linux-2.6.15-rc2-mm1/include/asm-x86_64/cacheflush.h.old 2005-11-24 06:12:03.000000000 +0100
+++ linux-2.6.15-rc2-mm1/include/asm-x86_64/cacheflush.h 2005-11-24 06:11:01.000000000 +0100
@@ -26,6 +26,9 @@
void global_flush_tlb(void);
int change_page_attr(struct page *page, int numpages, pgprot_t prot);
int change_page_attr_addr(unsigned long addr, int numpages, pgprot_t prot);
+
+#ifdef CONFIG_DEBUG_RODATA
void mark_rodata_ro(void);
+#endif
#endif /* _X8664_CACHEFLUSH_H */
--- linux-2.6.15-rc2-mm1/init/main.c.old 2005-11-24 05:56:17.000000000 +0100
+++ linux-2.6.15-rc2-mm1/init/main.c 2005-11-24 06:09:54.000000000 +0100
@@ -101,7 +101,7 @@
static inline void acpi_early_init(void) { }
#endif
#ifndef CONFIG_DEBUG_RODATA
-inline void mark_rodata_ro(void) { }
+static inline void mark_rodata_ro(void) { }
#endif
#ifdef CONFIG_TC
next prev parent reply other threads:[~2005-11-24 5:14 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-23 11:35 2.6.15-rc2-mm1 Andrew Morton
2005-11-23 13:35 ` 2.6.15-rc2-mm1 Serge E. Hallyn
2005-11-23 14:15 ` 2.6.15-rc2-mm1 Michal Piotrowski
2005-11-23 19:22 ` 2.6.15-rc2-mm1 Andrew Morton
2005-11-24 9:04 ` 2.6.15-rc2-mm1 Harald Welte
2005-11-23 14:24 ` 2.6.15-rc2-mm1 thunder7
2005-11-23 17:50 ` 2.6.15-rc2-mm1 Marc Koschewski
2005-11-23 19:33 ` 2.6.15-rc2-mm1 Ian McDonald
2005-11-23 19:50 ` 2.6.15-rc2-mm1 Marc Koschewski
2005-11-23 20:12 ` 2.6.15-rc2-mm1 Greg KH
2005-11-23 20:23 ` 2.6.15-rc2-mm1 Marc Koschewski
2005-11-23 19:38 ` 2.6.15-rc2-mm1 Andrew Morton
2005-11-24 2:06 ` Mouse issues in -mm Frank Sorenson
2005-11-24 3:26 ` Dmitry Torokhov
2005-11-24 6:14 ` Frank Sorenson
2005-11-25 22:31 ` Dmitry Torokhov
2005-11-24 9:40 ` Marc Koschewski
2005-11-25 22:27 ` Dmitry Torokhov
2005-11-26 2:52 ` Marc Koschewski
2005-11-26 3:50 ` Dmitry Torokhov
2005-11-23 20:25 ` 2.6.15-rc2-mm1 Benoit Boissinot
2005-11-23 22:35 ` [-mm patch] init/main.c: dummy mark_rodata_ro() should be static Adrian Bunk
2005-11-23 22:46 ` Randy.Dunlap
2005-11-23 22:54 ` Adrian Bunk
2005-11-24 4:21 ` Dave Jones
2005-11-24 5:05 ` Andrew Morton
2005-11-24 5:06 ` Adrian Bunk
2005-11-24 5:14 ` Adrian Bunk [this message]
2005-11-24 7:56 ` [-mm patch] " Arjan van de Ven
2005-11-25 15:49 ` Adrian Bunk
2005-11-24 7:56 ` [-mm patch] init/main.c: " Arjan van de Ven
2005-11-24 0:20 ` 2.6.15-rc2-mm1 J.A. Magallon
2005-11-24 0:27 ` 2.6.15-rc2-mm1 Andrew Morton
2005-11-24 3:18 ` 2.6.15-rc2-mm1 KAMEZAWA Hiroyuki
2005-11-24 5:02 ` 2.6.15-rc2-mm1 Andrew Morton
2005-11-25 13:36 ` [PATCH] oprofile : Use vmalloc_node() in alloc_cpu_buffers() Eric Dumazet
2005-11-24 18:48 ` 2.6.15-rc2-mm1 Alexandre Buisse
2005-11-26 5:49 ` 2.6.15-rc2-mm1 Valdis.Kletnieks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051124051405.GO3963@stusta.de \
--to=bunk@stusta.de \
--cc=akpm@osdl.org \
--cc=arjan@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.