All of lore.kernel.org
 help / color / mirror / Atom feed
* Generate SIGILL again
@ 2005-11-27  3:34 Daniel Jacobowitz
  0 siblings, 0 replies; only message in thread
From: Daniel Jacobowitz @ 2005-11-27  3:34 UTC (permalink / raw)
  To: ralf, linux-mips

The rdhwr emulation accidentally swallowed the SIGILL from most other
illegal instructions.  Make sure to return -EFAULT by default.

Signed-off-by: Daniel Jacobowitz <dan@codesourcery.com>

diff --git a/arch/mips/kernel/traps.c b/arch/mips/kernel/traps.c
index 7f60f61..63db2fa 100644
--- a/arch/mips/kernel/traps.c
+++ b/arch/mips/kernel/traps.c
@@ -534,13 +534,14 @@ static inline int simulate_rdhwr(struct 
 		switch (rd) {
 			case 29:
 				regs->regs[rt] = ti->tp_value;
-				break;
+				return 0;
 			default:
 				return -EFAULT;
 		}
 	}
 
-	return 0;
+	/* Not ours.  */
+	return -EFAULT;
 }
 
 asmlinkage void do_ov(struct pt_regs *regs)

-- 
Daniel Jacobowitz
CodeSourcery, LLC

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2005-11-27  3:31 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-11-27  3:34 Generate SIGILL again Daniel Jacobowitz

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.