All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] changed from pci_find_device to pci_get_device
Date: Mon, 28 Nov 2005 20:53:34 +0000	[thread overview]
Message-ID: <20051128205334.GF17740@kroah.com> (raw)
In-Reply-To: <438A0BE0.4010904@comhem.se>

[-- Attachment #1: Type: text/plain, Size: 621 bytes --]

On Sun, Nov 27, 2005 at 08:41:20PM +0100, Daniel Marjam?ki wrote:
> 
> 
> Hello friends!
> 
> I've made some changes and are interested in feedback 
> (drivers/ide/pci/via82cxxx.c).
> 
> Some notes:
> * The main change was to switch from pci_find_device to pci_get_device.
> * I unlock "isa" when it won't be used anymore
> * Changed a return value because init_chipset_via82cxxx returns an unsigned 
> value.
> 
> This is the patch in a readable format:

But it's not in a format that could be applied :(

Also, try splitting this up into 3 different patches, as you are doing
three different things.

thanks,

greg k-h

[-- Attachment #2: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

  reply	other threads:[~2005-11-28 20:53 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-27 19:41 [KJ] changed from pci_find_device to pci_get_device Daniel Marjamäki
2005-11-28 20:53 ` Greg KH [this message]
2005-11-28 21:43 ` Daniel Marjamäki
2005-11-29 11:44 ` Alexey Dobriyan
2005-11-29 11:51 ` Daniel Marjamäki
2005-11-29 12:58 ` Alexey Dobriyan
2005-11-29 13:20 ` Daniel Marjamäki
2005-11-29 13:56 ` Daniel Marjamäki
2005-11-29 17:34 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051128205334.GF17740@kroah.com \
    --to=greg@kroah.com \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.