All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Daniel Marjamäki" <daniel.marjamaki@comhem.se>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] changed from pci_find_device to pci_get_device
Date: Tue, 29 Nov 2005 13:20:34 +0000	[thread overview]
Message-ID: <438C55A2.4040407@comhem.se> (raw)
In-Reply-To: <438A0BE0.4010904@comhem.se>

[-- Attachment #1: Type: text/plain, Size: 436 bytes --]


>>About the chunk you didn't understand.
>>The function must return an unsigned int, therefore "return -ENODEV;" is
>>wrong.
> 
> 
> ->init_chipset method returns either small positive number (irq) or BIG
> positive number in case of error ((unsigned int) -ENODEV). In
> do_ide_setup_pci_device() function ->init_chipset return value is casted to int
> and checked for "< 0".
> 

I made a HUGE mistake then. Sorry.
Thank you Alexey!!


[-- Attachment #2: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

  parent reply	other threads:[~2005-11-29 13:20 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-27 19:41 [KJ] changed from pci_find_device to pci_get_device Daniel Marjamäki
2005-11-28 20:53 ` Greg KH
2005-11-28 21:43 ` Daniel Marjamäki
2005-11-29 11:44 ` Alexey Dobriyan
2005-11-29 11:51 ` Daniel Marjamäki
2005-11-29 12:58 ` Alexey Dobriyan
2005-11-29 13:20 ` Daniel Marjamäki [this message]
2005-11-29 13:56 ` Daniel Marjamäki
2005-11-29 17:34 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=438C55A2.4040407@comhem.se \
    --to=daniel.marjamaki@comhem.se \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.