From: Adrian Bunk <bunk@stusta.de>
To: Andi Kleen <ak@suse.de>
Cc: Christoph Lameter <clameter@engr.sgi.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linux-ia64@ver.kernel.org
Subject: Re: [RFC] Introduce atomic_long_t
Date: Fri, 9 Dec 2005 23:33:28 +0100 [thread overview]
Message-ID: <20051209223327.GH23349@stusta.de> (raw)
In-Reply-To: <20051209222045.GL11190@wotan.suse.de>
On Fri, Dec 09, 2005 at 11:20:45PM +0100, Andi Kleen wrote:
> > I'd say the sequence is:
> > 1. create an linux/atomic.h the #include's asm/atomic.h
> > 2. convert all asm/atomic.h to use linux/atomic.h
> > 3. move common code to linux/atomic.h
>
> I don't think there is much common code actually. atomic_t
> details vary widly between architectures. Just defining
> a few macros to others is really not significant. I think
> Christoph's original patch was just fine.
All of Christoph's original patch contains common code.
The amount of duplication his patch would create alone would IMHO be
worth creating an linux/atomic.h.
> -Andi
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
WARNING: multiple messages have this Message-ID (diff)
From: Adrian Bunk <bunk@stusta.de>
To: Andi Kleen <ak@suse.de>
Cc: Christoph Lameter <clameter@engr.sgi.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linux-ia64@ver.kernel.org
Subject: Re: [RFC] Introduce atomic_long_t
Date: Fri, 9 Dec 2005 23:33:28 +0100 [thread overview]
Message-ID: <20051209223327.GH23349@stusta.de> (raw)
In-Reply-To: <20051209222045.GL11190@wotan.suse.de>
On Fri, Dec 09, 2005 at 11:20:45PM +0100, Andi Kleen wrote:
> > I'd say the sequence is:
> > 1. create an linux/atomic.h the #include's asm/atomic.h
> > 2. convert all asm/atomic.h to use linux/atomic.h
> > 3. move common code to linux/atomic.h
>
> I don't think there is much common code actually. atomic_t
> details vary widly between architectures. Just defining
> a few macros to others is really not significant. I think
> Christoph's original patch was just fine.
All of Christoph's original patch contains common code.
The amount of duplication his patch would create alone would IMHO be
worth creating an linux/atomic.h.
> -Andi
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2005-12-09 22:33 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-09 18:58 [RFC] Introduce atomic_long_t Christoph Lameter
2005-12-09 18:58 ` Christoph Lameter
2005-12-09 20:11 ` Adrian Bunk
2005-12-09 20:11 ` Adrian Bunk
2005-12-09 21:57 ` Christoph Lameter
2005-12-09 21:57 ` Christoph Lameter
2005-12-09 22:02 ` Adrian Bunk
2005-12-09 22:02 ` Adrian Bunk
2005-12-09 22:20 ` Andi Kleen
2005-12-09 22:20 ` Andi Kleen
2005-12-09 22:33 ` Adrian Bunk [this message]
2005-12-09 22:33 ` Adrian Bunk
2005-12-09 22:50 ` Andi Kleen
2005-12-09 22:50 ` Andi Kleen
2005-12-09 22:58 ` Adrian Bunk
2005-12-09 22:58 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051209223327.GH23349@stusta.de \
--to=bunk@stusta.de \
--cc=ak@suse.de \
--cc=clameter@engr.sgi.com \
--cc=linux-ia64@ver.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.