All of lore.kernel.org
 help / color / mirror / Atom feed
From: "David S. Miller" <davem@davemloft.net>
To: trizt@iname.com
Cc: linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org
Subject: Re: Sparc: Kernel 2.6.13 to 2.6.15-rc2 bug when running X11
Date: Sat, 10 Dec 2005 23:00:34 +0000	[thread overview]
Message-ID: <20051210.150034.67577008.davem@davemloft.net> (raw)
In-Reply-To: <Pine.LNX.4.64.0512102350310.4739@lai.local.lan>

From: "J.O. Aho" <trizt@iname.com>
Date: Sat, 10 Dec 2005 23:52:01 +0100 (CET)

> IO[X:6761]: 
> remap_pfn_range(s[71800000]e[71c10000],f[71800000],pfn[1fc0060],sz[2000],prot[80000000000006b0])
> IO[X:6761]: 
> remap_pfn_range(s[71800000]e[71c10000],f[71802000],pfn[1fc0060],sz[2000],prot[80000000000006b0])

That's the problem, we're being called twice over the same
area.

Now we need to figure out why.  Please add this patch and give
us the new log output.  I'm going to a hockey game so I won't
be able to look at this until later this evening.

Thanks.

--- drivers/video/sbuslib.c.~1~	2005-11-13 17:58:46.000000000 -0800
+++ drivers/video/sbuslib.c	2005-12-10 15:00:25.000000000 -0800
@@ -52,6 +52,10 @@
 
 	off = vma->vm_pgoff << PAGE_SHIFT;
 
+#if 1
+	printk("sbusfb_mmap: start[%lx] size[%lx] off[%lx]\n",
+	       vma->vm_start, size, off);
+#endif
 	/* To stop the swapper from even considering these pages */
 	vma->vm_flags |= (VM_IO | VM_RESERVED);
 	
@@ -69,12 +73,19 @@
 				map_offset = (physbase + map[i].poff) & POFF_MASK;
 				break;
 			}
+#if 1
+		printk("sbusfb_mmap: page[%x] map_size[%lx]\n",
+		       page, map_size);
+#endif
 		if (!map_size){
 			page += PAGE_SIZE;
 			continue;
 		}
 		if (page + map_size > size)
 			map_size = size - page;
+#if 1
+		printk("sbusfb_mmap: map_size is now %lx\n", map_size);
+#endif
 		r = io_remap_pfn_range(vma,
 					vma->vm_start + page,
 					MK_IOSPACE_PFN(iospace,
@@ -85,6 +96,9 @@
 			return -EAGAIN;
 		page += map_size;
 	}
+#if 1
+	printk("sbusfb_mmap: Done\n");
+#endif
 
 	return 0;
 }

WARNING: multiple messages have this Message-ID (diff)
From: "David S. Miller" <davem@davemloft.net>
To: trizt@iname.com
Cc: linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org
Subject: Re: Sparc: Kernel 2.6.13 to 2.6.15-rc2 bug when running X11
Date: Sat, 10 Dec 2005 15:00:34 -0800 (PST)	[thread overview]
Message-ID: <20051210.150034.67577008.davem@davemloft.net> (raw)
In-Reply-To: <Pine.LNX.4.64.0512102350310.4739@lai.local.lan>

From: "J.O. Aho" <trizt@iname.com>
Date: Sat, 10 Dec 2005 23:52:01 +0100 (CET)

> IO[X:6761]: 
> remap_pfn_range(s[71800000]e[71c10000],f[71800000],pfn[1fc0060],sz[2000],prot[80000000000006b0])
> IO[X:6761]: 
> remap_pfn_range(s[71800000]e[71c10000],f[71802000],pfn[1fc0060],sz[2000],prot[80000000000006b0])

That's the problem, we're being called twice over the same
area.

Now we need to figure out why.  Please add this patch and give
us the new log output.  I'm going to a hockey game so I won't
be able to look at this until later this evening.

Thanks.

--- drivers/video/sbuslib.c.~1~	2005-11-13 17:58:46.000000000 -0800
+++ drivers/video/sbuslib.c	2005-12-10 15:00:25.000000000 -0800
@@ -52,6 +52,10 @@
 
 	off = vma->vm_pgoff << PAGE_SHIFT;
 
+#if 1
+	printk("sbusfb_mmap: start[%lx] size[%lx] off[%lx]\n",
+	       vma->vm_start, size, off);
+#endif
 	/* To stop the swapper from even considering these pages */
 	vma->vm_flags |= (VM_IO | VM_RESERVED);
 	
@@ -69,12 +73,19 @@
 				map_offset = (physbase + map[i].poff) & POFF_MASK;
 				break;
 			}
+#if 1
+		printk("sbusfb_mmap: page[%x] map_size[%lx]\n",
+		       page, map_size);
+#endif
 		if (!map_size){
 			page += PAGE_SIZE;
 			continue;
 		}
 		if (page + map_size > size)
 			map_size = size - page;
+#if 1
+		printk("sbusfb_mmap: map_size is now %lx\n", map_size);
+#endif
 		r = io_remap_pfn_range(vma,
 					vma->vm_start + page,
 					MK_IOSPACE_PFN(iospace,
@@ -85,6 +96,9 @@
 			return -EAGAIN;
 		page += map_size;
 	}
+#if 1
+	printk("sbusfb_mmap: Done\n");
+#endif
 
 	return 0;
 }

  reply	other threads:[~2005-12-10 23:00 UTC|newest]

Thread overview: 61+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-12-06  2:04 Sparc: Kernel 2.6.13 to 2.6.15-rc2 bug when running X11 J.O. Aho
2005-12-06  2:17 ` David S. Miller
2005-12-06  2:17   ` David S. Miller
2005-12-06 15:08   ` Christopher Zimmermann
2005-12-06 16:10   ` J.O. Aho
2005-12-06 16:10     ` J.O. Aho
2005-12-06 23:23     ` David S. Miller
2005-12-06 23:23       ` David S. Miller
2005-12-07 11:05       ` J.O. Aho
2005-12-07 11:05         ` J.O. Aho
2005-12-07 14:07         ` Ben Collins
2005-12-07 14:07           ` Ben Collins
2005-12-07 15:42           ` J.O. Aho
2005-12-07 15:42             ` J.O. Aho
2005-12-07 20:34         ` David S. Miller
2005-12-07 20:34           ` David S. Miller
2005-12-07 21:22           ` J.O. Aho
2005-12-07 21:22             ` J.O. Aho
2005-12-07 21:32             ` David S. Miller
2005-12-07 21:32               ` David S. Miller
2005-12-09 12:07               ` J.O. Aho
2005-12-09 12:07                 ` J.O. Aho
2005-12-10 22:25               ` J.O. Aho
2005-12-10 22:25                 ` J.O. Aho
2005-12-10 22:35                 ` David S. Miller
2005-12-10 22:35                   ` David S. Miller
2005-12-10 22:52                   ` J.O. Aho
2005-12-10 22:52                     ` J.O. Aho
2005-12-10 23:00                     ` David S. Miller [this message]
2005-12-10 23:00                       ` David S. Miller
2005-12-10 23:22                       ` J.O. Aho
2005-12-10 23:22                         ` J.O. Aho
2005-12-12  5:07                         ` David S. Miller
2005-12-12  5:07                           ` David S. Miller
2005-12-12  8:26                           ` J.O. Aho
2005-12-12  8:26                             ` J.O. Aho
2005-12-12 16:28                           ` J.O. Aho
2005-12-12 16:28                             ` J.O. Aho
2006-02-01 13:15                           ` J.O. Aho
2006-02-01 13:15                             ` J.O. Aho
2005-12-06 23:39   ` David S. Miller
2005-12-07 13:56   ` Christopher Zimmermann
2005-12-07 20:49   ` David S. Miller
2005-12-07 22:11   ` Christopher Zimmermann
2005-12-07 22:17   ` David S. Miller
2005-12-12 10:13   ` Mark Fortescue
2005-12-12 10:13     ` Mark Fortescue
2005-12-12 10:38     ` J.O. Aho
2005-12-12 10:38       ` J.O. Aho
2005-12-12 22:26       ` David S. Miller
2005-12-12 22:26         ` David S. Miller
2005-12-18 22:03         ` J.O. Aho
2005-12-18 22:03           ` J.O. Aho
2005-12-18 23:10           ` David S. Miller
2005-12-18 23:10             ` David S. Miller
2006-01-03 14:01         ` J.O. Aho
2006-01-03 14:01           ` J.O. Aho
2006-01-03 20:18           ` David S. Miller
2006-01-03 20:18             ` David S. Miller
2006-01-03 21:15             ` J.O. Aho
2006-01-03 21:15               ` J.O. Aho

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051210.150034.67577008.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sparclinux@vger.kernel.org \
    --cc=trizt@iname.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.