All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcelo Tosatti <marcelo.tosatti@cyclades.com>
To: Christoph Lameter <clameter@sgi.com>
Cc: linux-kernel@vger.kernel.org, Hugh Dickins <hugh@veritas.com>,
	Nick Piggin <nickpiggin@yahoo.com.au>,
	linux-mm@kvack.org, Andi Kleen <ak@suse.de>
Subject: Re: [RFC 3/6] Make nr_pagecache a per zone counter
Date: Sun, 11 Dec 2005 16:32:41 -0200	[thread overview]
Message-ID: <20051211183241.GD4267@dmt.cnet> (raw)
In-Reply-To: <20051210005456.3887.94412.sendpatchset@schroedinger.engr.sgi.com>

On Fri, Dec 09, 2005 at 04:54:56PM -0800, Christoph Lameter wrote:
> Make nr_pagecache a per node variable
> 
> Currently a single atomic variable is used to establish the size of the page cache
> in the whole machine. The zoned VM counters have the same method of implementation
> as the nr_pagecache code. Remove the special implementation for nr_pagecache and make
> it a zoned counter. We will then be able to figure out how much of the memory in a
> zone is used by the pagecache.
> 
> Updates of the page cache counters are always performed with interrupts off.
> We can therefore use the __ variant here.

By the way, why does nr_pagecache needs to be an atomic variable on UP systems?

#ifdef CONFIG_SMP
...
#else

static inline void pagecache_acct(int count)
{
        atomic_add(count, &nr_pagecache);
}
#endif


WARNING: multiple messages have this Message-ID (diff)
From: Marcelo Tosatti <marcelo.tosatti@cyclades.com>
To: Christoph Lameter <clameter@sgi.com>
Cc: linux-kernel@vger.kernel.org, Hugh Dickins <hugh@veritas.com>,
	Nick Piggin <nickpiggin@yahoo.com.au>,
	linux-mm@kvack.org, Andi Kleen <ak@suse.de>
Subject: Re: [RFC 3/6] Make nr_pagecache a per zone counter
Date: Sun, 11 Dec 2005 16:32:41 -0200	[thread overview]
Message-ID: <20051211183241.GD4267@dmt.cnet> (raw)
In-Reply-To: <20051210005456.3887.94412.sendpatchset@schroedinger.engr.sgi.com>

On Fri, Dec 09, 2005 at 04:54:56PM -0800, Christoph Lameter wrote:
> Make nr_pagecache a per node variable
> 
> Currently a single atomic variable is used to establish the size of the page cache
> in the whole machine. The zoned VM counters have the same method of implementation
> as the nr_pagecache code. Remove the special implementation for nr_pagecache and make
> it a zoned counter. We will then be able to figure out how much of the memory in a
> zone is used by the pagecache.
> 
> Updates of the page cache counters are always performed with interrupts off.
> We can therefore use the __ variant here.

By the way, why does nr_pagecache needs to be an atomic variable on UP systems?

#ifdef CONFIG_SMP
...
#else

static inline void pagecache_acct(int count)
{
        atomic_add(count, &nr_pagecache);
}
#endif

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2005-12-11 19:01 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-12-10  0:54 [RFC 0/6] Zoned VM stats Christoph Lameter
2005-12-10  0:54 ` Christoph Lameter
2005-12-10  0:54 ` [RFC 1/6] Framework Christoph Lameter
2005-12-10  0:54   ` Christoph Lameter
2005-12-10  3:32   ` Andi Kleen
2005-12-10  3:32     ` Andi Kleen
2005-12-12 16:32     ` Christoph Lameter
2005-12-12 16:32       ` Christoph Lameter
2005-12-12  3:46   ` Nick Piggin
2005-12-12  3:46     ` Nick Piggin
2005-12-12  3:56     ` Andi Kleen
2005-12-12  3:56       ` Andi Kleen
2005-12-12  4:14       ` Nick Piggin
2005-12-12  4:14         ` Nick Piggin
2005-12-12  4:21         ` Andi Kleen
2005-12-12  4:21           ` Andi Kleen
2005-12-12  4:28           ` Nick Piggin
2005-12-12  4:28             ` Nick Piggin
2005-12-12  4:51             ` Andi Kleen
2005-12-12  4:51               ` Andi Kleen
2005-12-12  7:05               ` Nick Piggin
2005-12-12  7:05                 ` Nick Piggin
2005-12-10  0:54 ` [RFC 2/6] Make nr_mapped a per zone counter Christoph Lameter
2005-12-10  0:54   ` Christoph Lameter
2005-12-10  0:54 ` [RFC 3/6] Make nr_pagecache " Christoph Lameter
2005-12-10  0:54   ` Christoph Lameter
2005-12-11 18:32   ` Marcelo Tosatti [this message]
2005-12-11 18:32     ` Marcelo Tosatti
2005-12-11 19:48     ` Andi Kleen
2005-12-11 19:48       ` Andi Kleen
2005-12-11 20:49       ` Marcelo Tosatti
2005-12-11 20:49         ` Marcelo Tosatti
2005-12-12  3:51         ` Nick Piggin
2005-12-12  3:51           ` Nick Piggin
2005-12-12 11:57           ` Marcelo Tosatti
2005-12-12 11:57             ` Marcelo Tosatti
2005-12-12 16:34             ` Christoph Lameter
2005-12-12 16:34               ` Christoph Lameter
2005-12-10  0:55 ` [RFC 4/6] Expanded node and zone statistics Christoph Lameter
2005-12-10  0:55   ` Christoph Lameter
2005-12-10  0:55 ` [RFC 5/6] Make nr_slab a per zone counter Christoph Lameter
2005-12-10  0:55   ` Christoph Lameter
2005-12-10  0:55 ` [RFC 6/6] Make nr_pagecache " Christoph Lameter
2005-12-10  0:55   ` Christoph Lameter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051211183241.GD4267@dmt.cnet \
    --to=marcelo.tosatti@cyclades.com \
    --cc=ak@suse.de \
    --cc=clameter@sgi.com \
    --cc=hugh@veritas.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=nickpiggin@yahoo.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.