From: Murillo Bernardes <mfb@br.ibm.com>
To: Ewan Mellor <ewan@xensource.com>
Cc: xen-devel@lists.xensource.com
Subject: Re: [PATCH] Talk_to_backend on xenbus_probe only if drv->probe was sucessful
Date: Thu, 15 Dec 2005 14:59:31 -0200 [thread overview]
Message-ID: <200512151459.31712.mfb@br.ibm.com> (raw)
In-Reply-To: <20051215133828.GB11024@leeni.uk.xensource.com>
On Thursday 15 December 2005 11:38, Ewan Mellor wrote:
> On Mon, Dec 12, 2005 at 04:35:45PM -0200, Murillo Bernardes wrote:
> > Hi,
> >
> > This patch makes xenbus_probe only call talk_to_backend if drv->probe()
> > was sucessful.
> >
> > There is no sense in add a watch before drv->probe, because if it fails
> > the otherend_changed callback will be called and receive a struct with
> > invalid pointers and we get a segfault (ooops).
>
> Applied, thanks Murillo.
>
> Ewan.
I just found a problem on that. It breaks block devices! I don't know why yet.
Do you know why block devices rely on that watch before probe?
Thanks
--
Murillo Fernandes Bernardes
IBM Linux Technology Center
next prev parent reply other threads:[~2005-12-15 16:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-12 18:35 [PATCH] Talk_to_backend on xenbus_probe only if drv->probe was sucessful Murillo Bernardes
2005-12-15 13:38 ` Ewan Mellor
2005-12-15 16:59 ` Murillo Bernardes [this message]
2005-12-15 17:18 ` Ewan Mellor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200512151459.31712.mfb@br.ibm.com \
--to=mfb@br.ibm.com \
--cc=ewan@xensource.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.