From: Ingo Molnar <mingo@elte.hu>
To: David Woodhouse <dwmw2@infradead.org>
Cc: Zwane Mwaikambo <zwane@arm.linux.org.uk>,
linux-kernel@vger.kernel.org, Linus Torvalds <torvalds@osdl.org>,
Andrew Morton <akpm@osdl.org>,
Arjan van de Ven <arjanv@infradead.org>,
Steven Rostedt <rostedt@goodmis.org>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
Christoph Hellwig <hch@infradead.org>, Andi Kleen <ak@suse.de>,
David Howells <dhowells@redhat.com>,
Alexander Viro <viro@parcelfarce.linux.theplanet.co.uk>,
Oleg Nesterov <oleg@tv-sign.ru>, Paul Jackson <pj@sgi.com>
Subject: Re: [patch 04/15] Generic Mutex Subsystem, add-atomic-call-func-x86_64.patch
Date: Tue, 20 Dec 2005 05:31:09 +0100 [thread overview]
Message-ID: <20051220043109.GC32039@elte.hu> (raw)
In-Reply-To: <1135025932.4760.1.camel@localhost.localdomain>
* David Woodhouse <dwmw2@infradead.org> wrote:
> On Mon, 2005-12-19 at 09:49 -0800, Zwane Mwaikambo wrote:
> > Hi Ingo,
> > Doesn't this corrupt caller saved registers?
>
> Looks like it. I _really_ don't like calling functions from inline
> asm. It's not nice. Can't we use atomic_dec_return() for this?
we can use atomic_dec_return(), but that will add one more instruction
to the fastpath. OTOH, atomic_dec_return() is available on every
architecture, so it's a really tempting thing. I'll experiment with it.
Ingo
next prev parent reply other threads:[~2005-12-20 4:31 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-19 1:35 [patch 04/15] Generic Mutex Subsystem, add-atomic-call-func-x86_64.patch Ingo Molnar
2005-12-19 17:49 ` Zwane Mwaikambo
2005-12-19 20:58 ` David Woodhouse
2005-12-20 4:31 ` Ingo Molnar [this message]
2005-12-20 6:30 ` Nicolas Pitre
2005-12-20 8:12 ` Nick Piggin
2005-12-20 14:10 ` Nicolas Pitre
2005-12-20 14:12 ` Nick Piggin
2005-12-20 14:35 ` Nicolas Pitre
2005-12-20 15:05 ` Nick Piggin
2005-12-20 16:35 ` Nicolas Pitre
2005-12-20 19:20 ` Russell King
2005-12-20 19:32 ` Arjan van de Ven
2005-12-20 19:37 ` Russell King
2005-12-20 19:59 ` Nicolas Pitre
2005-12-20 19:43 ` Steven Rostedt
2005-12-20 19:57 ` Russell King
2005-12-20 20:35 ` Horst von Brand
2005-12-20 19:55 ` Nicolas Pitre
2005-12-20 18:27 ` Linus Torvalds
2005-12-20 19:34 ` Russell King
2005-12-20 20:10 ` Linus Torvalds
2005-12-20 21:18 ` Nicolas Pitre
2005-12-20 22:04 ` Linus Torvalds
2005-12-20 22:19 ` Steven Rostedt
2005-12-20 22:43 ` Nicolas Pitre
2005-12-21 6:00 ` Ingo Molnar
2005-12-21 2:12 ` Nick Piggin
2005-12-20 19:49 ` Nicolas Pitre
2005-12-20 18:25 ` Linus Torvalds
2005-12-21 6:20 ` Ingo Molnar
2005-12-21 4:16 ` Nicolas Pitre
2005-12-21 6:26 ` Ingo Molnar
2005-12-20 4:29 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051220043109.GC32039@elte.hu \
--to=mingo@elte.hu \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=arjanv@infradead.org \
--cc=dhowells@redhat.com \
--cc=dwmw2@infradead.org \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@tv-sign.ru \
--cc=pj@sgi.com \
--cc=rostedt@goodmis.org \
--cc=torvalds@osdl.org \
--cc=viro@parcelfarce.linux.theplanet.co.uk \
--cc=zwane@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.