From: Mark Maule <maule@sgi.com>
To: Matthew Wilcox <matthew@wil.cx>
Cc: linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org,
Tony Luck <tony.luck@intel.com>
Subject: Re: [PATCH 1/4] msi archetecture init hook
Date: Wed, 21 Dec 2005 19:03:49 +0000 [thread overview]
Message-ID: <20051221190349.GH9920@sgi.com> (raw)
In-Reply-To: <20051221185346.GC2361@parisc-linux.org>
On Wed, Dec 21, 2005 at 11:53:46AM -0700, Matthew Wilcox wrote:
> On Wed, Dec 21, 2005 at 12:42:36PM -0600, Mark Maule wrote:
> > Index: msi/include/asm-sparc/msi.h
> > =================================> > --- msi.orig/include/asm-sparc/msi.h 2005-12-13 12:22:42.785246074 -0600
> > +++ msi/include/asm-sparc/msi.h 2005-12-13 16:09:49.194541334 -0600
> > @@ -28,4 +28,6 @@
> > "i" (ASI_M_CTL), "r" (MSI_ASYNC_MODE) : "g3");
> > }
> >
> > +static inline int msi_arch_init(void) { return 0; }
> > +
> > #endif /* !(_SPARC_MSI_H) */
>
> As far as I can tell, you can't select MSI on Sparc, so this doesn't
> need to be here ...
Ok. I'm a little confused on why we have asm-sparc/msi.h then. Should I
yank it, or leave it for consistency and return -EINVAL so pci_enable_msi()
could fail somewhat gracefully on sparc ?
Mark
WARNING: multiple messages have this Message-ID (diff)
From: Mark Maule <maule@sgi.com>
To: Matthew Wilcox <matthew@wil.cx>
Cc: linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org,
Tony Luck <tony.luck@intel.com>
Subject: Re: [PATCH 1/4] msi archetecture init hook
Date: Wed, 21 Dec 2005 13:03:49 -0600 [thread overview]
Message-ID: <20051221190349.GH9920@sgi.com> (raw)
In-Reply-To: <20051221185346.GC2361@parisc-linux.org>
On Wed, Dec 21, 2005 at 11:53:46AM -0700, Matthew Wilcox wrote:
> On Wed, Dec 21, 2005 at 12:42:36PM -0600, Mark Maule wrote:
> > Index: msi/include/asm-sparc/msi.h
> > ===================================================================
> > --- msi.orig/include/asm-sparc/msi.h 2005-12-13 12:22:42.785246074 -0600
> > +++ msi/include/asm-sparc/msi.h 2005-12-13 16:09:49.194541334 -0600
> > @@ -28,4 +28,6 @@
> > "i" (ASI_M_CTL), "r" (MSI_ASYNC_MODE) : "g3");
> > }
> >
> > +static inline int msi_arch_init(void) { return 0; }
> > +
> > #endif /* !(_SPARC_MSI_H) */
>
> As far as I can tell, you can't select MSI on Sparc, so this doesn't
> need to be here ...
Ok. I'm a little confused on why we have asm-sparc/msi.h then. Should I
yank it, or leave it for consistency and return -EINVAL so pci_enable_msi()
could fail somewhat gracefully on sparc ?
Mark
next prev parent reply other threads:[~2005-12-21 19:03 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-21 18:42 [PATCH 0/4] msi abstractions and support for altix Mark Maule
2005-12-21 18:42 ` Mark Maule
2005-12-21 18:42 ` [PATCH 1/4] msi archetecture init hook Mark Maule
2005-12-21 18:42 ` Mark Maule
2005-12-21 18:53 ` Matthew Wilcox
2005-12-21 18:53 ` Matthew Wilcox
2005-12-21 19:03 ` Mark Maule [this message]
2005-12-21 19:03 ` Mark Maule
2005-12-21 19:40 ` Matthew Wilcox
2005-12-21 19:40 ` Matthew Wilcox
2005-12-21 18:42 ` [PATCH 2/4] msi vector targeting abstractions Mark Maule
2005-12-21 18:42 ` Mark Maule
2005-12-21 18:56 ` Christoph Hellwig
2005-12-21 18:56 ` Christoph Hellwig
2005-12-21 19:17 ` Mark Maule
2005-12-21 19:17 ` Mark Maule
2005-12-21 19:05 ` Matthew Wilcox
2005-12-21 19:05 ` Matthew Wilcox
2005-12-21 19:17 ` linux-os (Dick Johnson)
2005-12-21 19:17 ` linux-os (Dick Johnson)
2005-12-21 19:33 ` Mark Maule
2005-12-21 19:33 ` Mark Maule
2005-12-22 10:36 ` Christoph Hellwig
2005-12-22 13:59 ` Mark Maule
2005-12-22 13:59 ` Mark Maule
2005-12-21 18:42 ` [PATCH 3/4] per-platform IA64_{FIRST,LAST}_DEVICE_VECTOR definitions Mark Maule
2005-12-21 18:42 ` Mark Maule
2005-12-21 19:09 ` Matthew Wilcox
2005-12-21 19:09 ` Matthew Wilcox
2005-12-21 19:18 ` Mark Maule
2005-12-21 19:18 ` Mark Maule
2005-12-21 19:32 ` Matthew Wilcox
2005-12-21 19:32 ` Matthew Wilcox
2005-12-22 6:26 ` Keith Owens
2005-12-22 6:26 ` Keith Owens
2005-12-22 13:14 ` Matthew Wilcox
2005-12-22 13:14 ` Matthew Wilcox
2005-12-21 18:42 ` [PATCH 4/4] altix: msi support Mark Maule
2005-12-21 18:42 ` Mark Maule
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051221190349.GH9920@sgi.com \
--to=maule@sgi.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.