Re: [PATCH 0/5] SATA/ACPI suspend/resume support

[Randy Dunlap <randy_d_dunlap@linux.intel.com>]

On Tue, 3 Jan 2006 20:03:47 +0100
Jens Axboe <axboe@suse.de> wrote:

> On Tue, Jan 03 2006, Jens Axboe wrote:
> > On Tue, Jan 03 2006, Randy Dunlap wrote:
> > > On 30 Dec 2005 17:36:44 +0900
> > > Jae-hyeon Park <jhpark@tuhep.phys.tohoku.ac.jp> wrote:
> > > 
> > > > I tested kernel 2.6.15-rc7 with your patch applied on my ThinkPad X41.
> > > > While booting, it locks up after printing
> > > > 
> > > >     ata1: SATA max UDMA/133 cmd 0x1F0 ctl 0x3F6 bmdma 0x1810 irq 14
> > > >     ata1: dev 0 ATA-6, max UDMA/100, 117210240 sectors: LBA
> > > >     ata1(0): applying bridge limits
> > > >     ata1: dev 0 configured for UDMA/100
> > > > 
> > > > If I select CONFIG_SCSI_SATA_AHCI, then the kernel emits an oops and
> > > > panics during boot.
> > > 
> > > Hi,
> > > 
> > > Can you capture the kernel oops & panic messages?
> > 
> > I think I triggered the same oops on my T43, I'll try applying your sata
> > acpi patches and see if it reproduces.
> 
> It's crashing here:
> 
>                 acpi_os_free((void *)gtf_address);
> 
> in ata_acpi_exec_tfs(), looks like it's trying to free an uninitialized
> gtf_address. Setting to 0 and doing:
> 
>         if (gtf_address)
>                 acpi_os_free((void *)gtf_address);
> 
> fixes it. Probably due to a nasty warning that it spews on boot:
> 
> ata1: SATA max UDMA/133 cmd 0x1F0 ctl 0x3F6 bmdma 0x18C0 irq 14
> ata1: dev 0 cfg 49:2f00 82:346b 83:7d09 84:6003 85:3469 86:3c09 87:6003
> 88:203f
> ata1: dev 0 ATA-7, max UDMA/100, 156301488 sectors: LBA48
> ata1(0): applying bridge limits
> ata1: dev 0 configured for UDMA/100
> ata_acpi_exec_tfs: call get_GTF, ix=0
> ata_acpi_exec_tfs: call set_taskfiles, ix=0
> do_drive_set_taskfiles: unexpected GTF length (-271707516)
> scsi0 : ata_piix
>   Vendor: ATA       Model: ST980825A         Rev: 3.04
>   Type:   Direct-Access                      ANSI SCSI revision: 05
> 
> note the 'unexpected GTF length' message. Doing a suspend/resume cycle
> doesn't trigger that error:
> 
> [...]
> eth1: Coming out of suspend...
> ACPI: PCI Interrupt 0000:04:02.0[A] -> GSI 21 (level, low) -> IRQ 23
> ata1: dev 0 configured for UDMA/100
> ata_acpi_exec_tfs: call get_GTF, ix=0
> ata_acpi_exec_tfs: call set_taskfiles, ix=0
> Restarting tasks... done
> [...]

Thanks, I'll get right on it.
---
~Randy