Re: [PATCH 0/5] SATA/ACPI suspend/resume support

[Jens Axboe <axboe@suse.de>]

[-- Attachment #1: Type: text/plain, Size: 1380 bytes --]

On Tue, Jan 03 2006, Randy Dunlap wrote:
> > ata1: SATA max UDMA/133 cmd 0x1F0 ctl 0x3F6 bmdma 0x18C0 irq 14
> > ata1: dev 0 cfg 49:2f00 82:346b 83:7d09 84:6003 85:3469 86:3c09 87:6003
> > 88:203f
> > ata1: dev 0 ATA-7, max UDMA/100, 156301488 sectors: LBA48
> > ata1(0): applying bridge limits
> > ata1: dev 0 configured for UDMA/100
> > ata_acpi_exec_tfs: call get_GTF, ix=0
> > ata_acpi_exec_tfs: call set_taskfiles, ix=0
> > do_drive_set_taskfiles: unexpected GTF length (-271707516)
> 
> Ugh.  So the ACPI taskfile data looks like crap??
> I guess that I'll just invalidate gtf_address (set to NULL)
> if gtf_length looks invalid.  Is there something better to do?

Bugger me, I'm totally acpi ignorant. But did you see my note that if I
clear gtf_address before calling into the function (where you pass it by
reference), the problem goes away? That smells more like return-on-error
without setting it at all, hence kfree() blows up when passed a bogus
stack filled variable.

> Jae-hyeon,
> 
> Please send me a dump of your ACPI tables (acpidump).
> 'acpidump' is at
> http://www.kernel.org/pub/linux/kernel/people/lenb/acpi/utils/ .
> Use the latest pmtools tarball.

I've attached mine as well, in case they are useful.

> Jens, could you see that <gtf_address> your system is
> getting that is invalid?

Sure, will reboot it after posting this message.

-- 
Jens Axboe


[-- Attachment #2: acpi.tables.bz2 --]
[-- Type: application/x-bunzip2, Size: 58667 bytes --]