From: Matt Domsch <Matt_Domsch@dell.com>
To: "Tolentino, Matthew E" <matthew.e.tolentino@intel.com>
Cc: linux-ia64@vger.kernel.org, ak@suse.de,
openipmi-developer@lists.sourceforge.net, akpm@osdl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.15] ia64: use i386 dmi_scan.c
Date: Fri, 06 Jan 2006 22:36:52 +0000 [thread overview]
Message-ID: <20060106223652.GA9230@lists.us.dell.com> (raw)
In-Reply-To: <D36CE1FCEFD3524B81CA12C6FE5BCAB00C081899@fmsmsx406.amr.corp.intel.com>
On Fri, Jan 06, 2006 at 11:03:17AM -0800, Tolentino, Matthew E wrote:
> Matt Domsch <> wrote:
> > Enable DMI table parsing on ia64.
> ...
> > +#ifndef CONFIG_EFI
> > +void __init dmi_scan_machine(void)
> > +{
> > char __iomem *p, *q;
> > + int rc;
>
> Hi Matt,
>
> You could potentially consolidate the two dmi_scan_machine functions
> and lose the ifdef (and duplication) by checking efi_enabled instead.
> 'efi_enabled' is already ifdef'd in the EFI header (defined to 1 for
> ia64) specifically for this situation.
Good idea, patch to follow.
--
Matt Domsch
Software Architect
Dell Linux Solutions linux.dell.com & www.dell.com/linux
Linux on Dell mailing lists @ http://lists.us.dell.com
WARNING: multiple messages have this Message-ID (diff)
From: Matt Domsch <Matt_Domsch@dell.com>
To: "Tolentino, Matthew E" <matthew.e.tolentino@intel.com>
Cc: linux-ia64@vger.kernel.org, ak@suse.de,
openipmi-developer@lists.sourceforge.net, akpm@osdl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.15] ia64: use i386 dmi_scan.c
Date: Fri, 6 Jan 2006 16:36:52 -0600 [thread overview]
Message-ID: <20060106223652.GA9230@lists.us.dell.com> (raw)
In-Reply-To: <D36CE1FCEFD3524B81CA12C6FE5BCAB00C081899@fmsmsx406.amr.corp.intel.com>
On Fri, Jan 06, 2006 at 11:03:17AM -0800, Tolentino, Matthew E wrote:
> Matt Domsch <> wrote:
> > Enable DMI table parsing on ia64.
> ...
> > +#ifndef CONFIG_EFI
> > +void __init dmi_scan_machine(void)
> > +{
> > char __iomem *p, *q;
> > + int rc;
>
> Hi Matt,
>
> You could potentially consolidate the two dmi_scan_machine functions
> and lose the ifdef (and duplication) by checking efi_enabled instead.
> 'efi_enabled' is already ifdef'd in the EFI header (defined to 1 for
> ia64) specifically for this situation.
Good idea, patch to follow.
--
Matt Domsch
Software Architect
Dell Linux Solutions linux.dell.com & www.dell.com/linux
Linux on Dell mailing lists @ http://lists.us.dell.com
next prev parent reply other threads:[~2006-01-06 22:36 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-04 22:16 [PATCH 2.6.15 1/2] ia64: use i386 dmi_scan.c Matt Domsch
2006-01-04 22:16 ` Matt Domsch
2006-01-04 22:36 ` Alex Williamson
2006-01-04 22:36 ` Alex Williamson
2006-01-04 23:29 ` Matt Domsch
2006-01-04 23:29 ` Matt Domsch
2006-01-05 16:41 ` Bjorn Helgaas
2006-01-05 16:41 ` Bjorn Helgaas
2006-01-05 17:37 ` Matt Domsch
2006-01-05 17:37 ` Matt Domsch
2006-01-05 17:54 ` Bjorn Helgaas
2006-01-05 17:54 ` Bjorn Helgaas
2006-01-06 0:02 ` Bjorn Helgaas
2006-01-06 0:02 ` Bjorn Helgaas
2006-01-06 17:15 ` Matt Domsch
2006-01-06 17:15 ` Matt Domsch
2006-01-04 22:55 ` Alan Cox
2006-01-06 17:21 ` [PATCH 2.6.15] " Matt Domsch
2006-01-06 17:21 ` Matt Domsch
2006-01-06 19:03 ` Tolentino, Matthew E
2006-01-06 19:03 ` Tolentino, Matthew E
2006-01-06 22:36 ` Matt Domsch [this message]
2006-01-06 22:36 ` Matt Domsch
2006-01-06 22:39 ` Matt Domsch
2006-01-06 22:39 ` Matt Domsch
2006-01-14 0:24 ` Bjorn Helgaas
2006-01-14 0:24 ` Bjorn Helgaas
2006-01-14 0:45 ` Alan Cox
2006-01-14 1:19 ` Andi Kleen
2006-01-14 1:19 ` Andi Kleen
2006-01-14 5:05 ` Bjorn Helgaas
2006-01-14 5:05 ` Bjorn Helgaas
2006-01-18 0:17 ` Bjorn Helgaas
2006-01-18 0:17 ` Bjorn Helgaas
2006-01-18 2:32 ` Andi Kleen
2006-01-18 2:32 ` Andi Kleen
2006-01-18 15:53 ` Bjorn Helgaas
2006-01-18 15:53 ` Bjorn Helgaas
2006-01-18 17:29 ` Bjorn Helgaas
2006-01-18 17:29 ` Bjorn Helgaas
2006-01-18 18:11 ` [Openipmi-developer] " Matt Domsch
2006-01-18 18:11 ` Matt Domsch
2006-01-19 20:10 ` [PATCH 0/5] ia64 ioremap, DMI, EFI system table Bjorn Helgaas
2006-01-19 20:10 ` Bjorn Helgaas
2006-01-19 20:10 ` Bjorn Helgaas
2006-01-19 20:12 ` [PATCH 1/5] EFI, /dev/mem: simplify efi_mem_attribute_range() Bjorn Helgaas
2006-01-19 20:12 ` Bjorn Helgaas
2006-01-19 20:12 ` Bjorn Helgaas
2006-01-19 20:12 ` [PATCH 2/5] ia64: ioremap: check EFI for valid memory attributes Bjorn Helgaas
2006-01-19 20:12 ` Bjorn Helgaas
2006-01-19 20:12 ` Bjorn Helgaas
2006-01-19 20:13 ` [PATCH 3/5] DMI: only ioremap stuff we actually need Bjorn Helgaas
2006-01-19 20:13 ` Bjorn Helgaas
2006-01-19 20:13 ` [PATCH 4/5] EFI: keep physical table addresses in efi structure Bjorn Helgaas
2006-01-19 20:13 ` Bjorn Helgaas
2006-01-19 20:14 ` [PATCH 5/5] ACPI: clean up memory attribute checking for map/read/write Bjorn Helgaas
2006-01-19 20:14 ` Bjorn Helgaas
2006-01-19 20:14 ` Bjorn Helgaas
2006-01-30 17:11 ` [Openipmi-developer] [PATCH 0/5] ia64 ioremap, DMI, EFI system table Matt Domsch
2006-01-30 17:11 ` Matt Domsch
2006-03-17 23:54 ` [PATCH 2.6.15] ia64: use i386 dmi_scan.c Andrew Morton
2006-03-17 23:54 ` Andrew Morton
2006-03-18 14:56 ` Matt Domsch
2006-03-18 14:56 ` Matt Domsch
2006-03-18 15:43 ` Matt Domsch
2006-03-18 15:43 ` Matt Domsch
2006-03-18 19:51 ` Andrew Morton
2006-03-18 19:51 ` Andrew Morton
2006-01-19 14:19 ` Tolentino, Matthew E
2006-01-19 14:19 ` Tolentino, Matthew E
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060106223652.GA9230@lists.us.dell.com \
--to=matt_domsch@dell.com \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.e.tolentino@intel.com \
--cc=openipmi-developer@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.