From: Dmitry Torokhov <dtor_core@ameritech.net>
To: Miloslav Trmac <mitr@volny.cz>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] wistron_btns: Fix missing BIOS signature handling, take 2
Date: Sun, 8 Jan 2006 11:13:19 -0500 [thread overview]
Message-ID: <200601081113.20177.dtor_core@ameritech.net> (raw)
In-Reply-To: <43C0C4BA.8000800@volny.cz>
On Sunday 08 January 2006 02:52, Miloslav Trmac wrote:
> Dmitry Torokhov wrote:
> > On Sunday 08 January 2006 01:39, Miloslav Trmac wrote:
> >
> >>offset can never be < 0 because it has type size_t. The driver
> >>currently oopses on insmod if BIOS does not support the interface,
> >>instead of refusing to load.
> >
> > I don't really like that casting, should we just change offset to ssize_t?
> Sure.
> Mirek
>
Thank you, I will add this to input tree.
--
Dmitry
prev parent reply other threads:[~2006-01-08 16:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-08 6:39 [PATCH] wistron_btns: Fix missing BIOS signature handling Miloslav Trmac
2006-01-08 6:58 ` Dmitry Torokhov
2006-01-08 7:52 ` [PATCH] wistron_btns: Fix missing BIOS signature handling, take 2 Miloslav Trmac
2006-01-08 16:13 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200601081113.20177.dtor_core@ameritech.net \
--to=dtor_core@ameritech.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mitr@volny.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.