From: Miloslav Trmac <mitr@volny.cz>
To: Dmitry Torokhov <dtor_core@ameritech.net>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: [PATCH] wistron_btns: Fix missing BIOS signature handling
Date: Sun, 08 Jan 2006 07:39:59 +0100 [thread overview]
Message-ID: <43C0B3BF.5050100@volny.cz> (raw)
[-- Attachment #1: Type: text/plain, Size: 160 bytes --]
offset can never be < 0 because it has type size_t. The driver
currently oopses on insmod if BIOS does not support the interface,
instead of refusing to load.
[-- Attachment #2: wistron-no-entry.patch --]
[-- Type: text/x-patch, Size: 640 bytes --]
offset can never be < 0 because it has type size_t. The driver
currently oopses on insmod if BIOS does not support the interface,
instead of refusing to load.
Signed-off-by: Miloslav Trmac <mitr@volny.cz>
diff -r 88ae680122c0 wistron_btns.c
--- a/drivers/input/misc/wistron_btns.c Sun Dec 11 21:18:28 2005
+++ b/drivers/input/misc/wistron_btns.c Sun Jan 8 07:24:44 2006
@@ -114,7 +114,7 @@
base = ioremap(0xF0000, 0x10000); /* Can't fail */
offset = locate_wistron_bios(base);
- if (offset < 0) {
+ if (offset == (size_t)-1) {
printk(KERN_ERR "wistron_btns: BIOS entry point not found\n");
iounmap(base);
return -ENODEV;
next reply other threads:[~2006-01-08 6:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-08 6:39 Miloslav Trmac [this message]
2006-01-08 6:58 ` [PATCH] wistron_btns: Fix missing BIOS signature handling Dmitry Torokhov
2006-01-08 7:52 ` [PATCH] wistron_btns: Fix missing BIOS signature handling, take 2 Miloslav Trmac
2006-01-08 16:13 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43C0B3BF.5050100@volny.cz \
--to=mitr@volny.cz \
--cc=dtor_core@ameritech.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.