All of lore.kernel.org
 help / color / mirror / Atom feed
* [KJ] [PATCH] printk : arch/arm/kernel/irq.c
@ 2006-01-10 11:42 Christophe Lucas
  0 siblings, 0 replies; only message in thread
From: Christophe Lucas @ 2006-01-10 11:42 UTC (permalink / raw)
  To: kernel-janitors

[-- Attachment #1: Type: text/plain, Size: 1158 bytes --]

Description:
printk should include appropriate KERN_* constant (of course
only at beginning of lines).

Signed-off-by: Christophe Lucas <clucas@rotomalug.org>

Index: linux-2.6.15/arch/arm/kernel/irq.c
===================================================================
--- linux-2.6.15.orig/arch/arm/kernel/irq.c	2006-01-03 04:21:10.000000000 +0100
+++ linux-2.6.15/arch/arm/kernel/irq.c	2006-01-07 11:27:02.000000000 +0100
@@ -175,8 +175,8 @@
 
 	spin_lock_irqsave(&irq_controller_lock, flags);
 	if (unlikely(!desc->disable_depth)) {
-		printk("enable_irq(%u) unbalanced from %p\n", irq,
-			__builtin_return_address(0));
+		printk(KERN_INFO "enable_irq(%u) unbalanced from %p\n",
+			irq, __builtin_return_address(0));
 	} else if (!--desc->disable_depth) {
 		desc->probing = 0;
 		desc->chip->unmask(irq);
@@ -311,9 +311,9 @@
 	count--;
 
 	if (ret != IRQ_HANDLED && ret != IRQ_NONE) {
-		printk("irq%u: bogus retval mask %x\n", irq, ret);
+		printk(KERN_WARNING "irq%u: bogus retval mask %x\n", irq, ret);
 	} else {
-		printk("irq%u: nobody cared\n", irq);
+		printk(KERN_WARNING "irq%u: nobody cared\n", irq);
 	}
 	show_regs(regs);
 	dump_stack();

[-- Attachment #2: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2006-01-10 11:42 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-01-10 11:42 [KJ] [PATCH] printk : arch/arm/kernel/irq.c Christophe Lucas

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.