* [2.6 patch] let SND_SUPPORT_OLD_API depend on SND_PCM
@ 2006-01-10 16:44 Adrian Bunk
2006-01-10 17:00 ` [Alsa-devel] " Takashi Iwai
0 siblings, 1 reply; 6+ messages in thread
From: Adrian Bunk @ 2006-01-10 16:44 UTC (permalink / raw)
To: perex; +Cc: alsa-devel, linux-kernel
SND_SUPPORT_OLD_API only has an effect if SND_PCM is set.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.15-mm2-full/sound/core/Kconfig.old 2006-01-10 17:35:35.000000000 +0100
+++ linux-2.6.15-mm2-full/sound/core/Kconfig 2006-01-10 17:36:07.000000000 +0100
@@ -124,7 +124,7 @@
config SND_SUPPORT_OLD_API
bool "Support old ALSA API"
- depends on SND
+ depends on SND_PCM
default y
help
Say Y here to support the obsolete ALSA PCM API (ver.0.9.0 rc3
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [2.6 patch] let SND_SUPPORT_OLD_API depend on SND_PCM
2006-01-10 16:44 [2.6 patch] let SND_SUPPORT_OLD_API depend on SND_PCM Adrian Bunk
@ 2006-01-10 17:00 ` Takashi Iwai
0 siblings, 0 replies; 6+ messages in thread
From: Takashi Iwai @ 2006-01-10 17:00 UTC (permalink / raw)
To: Adrian Bunk; +Cc: alsa-devel, linux-kernel
At Tue, 10 Jan 2006 17:44:49 +0100,
Adrian Bunk wrote:
>
> SND_SUPPORT_OLD_API only has an effect if SND_PCM is set.
>
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
>
> --- linux-2.6.15-mm2-full/sound/core/Kconfig.old 2006-01-10 17:35:35.000000000 +0100
> +++ linux-2.6.15-mm2-full/sound/core/Kconfig 2006-01-10 17:36:07.000000000 +0100
> @@ -124,7 +124,7 @@
>
> config SND_SUPPORT_OLD_API
> bool "Support old ALSA API"
> - depends on SND
> + depends on SND_PCM
> default y
> help
> Say Y here to support the obsolete ALSA PCM API (ver.0.9.0 rc3
Does it work? CONFIG_SND_PCM is selected by the drivers. So, it will
be N until any drivers are selected.
Takashi
-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems? Stop! Download the new AJAX search engine that makes
searching your log files as easy as surfing the web. DOWNLOAD SPLUNK!
http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Alsa-devel] [2.6 patch] let SND_SUPPORT_OLD_API depend on SND_PCM
@ 2006-01-10 17:00 ` Takashi Iwai
0 siblings, 0 replies; 6+ messages in thread
From: Takashi Iwai @ 2006-01-10 17:00 UTC (permalink / raw)
To: Adrian Bunk; +Cc: alsa-devel, linux-kernel
At Tue, 10 Jan 2006 17:44:49 +0100,
Adrian Bunk wrote:
>
> SND_SUPPORT_OLD_API only has an effect if SND_PCM is set.
>
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
>
> --- linux-2.6.15-mm2-full/sound/core/Kconfig.old 2006-01-10 17:35:35.000000000 +0100
> +++ linux-2.6.15-mm2-full/sound/core/Kconfig 2006-01-10 17:36:07.000000000 +0100
> @@ -124,7 +124,7 @@
>
> config SND_SUPPORT_OLD_API
> bool "Support old ALSA API"
> - depends on SND
> + depends on SND_PCM
> default y
> help
> Say Y here to support the obsolete ALSA PCM API (ver.0.9.0 rc3
Does it work? CONFIG_SND_PCM is selected by the drivers. So, it will
be N until any drivers are selected.
Takashi
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Alsa-devel] [2.6 patch] let SND_SUPPORT_OLD_API depend on SND_PCM
2006-01-10 17:00 ` [Alsa-devel] " Takashi Iwai
(?)
@ 2006-01-10 17:08 ` Adrian Bunk
2006-01-10 17:39 ` Takashi Iwai
-1 siblings, 1 reply; 6+ messages in thread
From: Adrian Bunk @ 2006-01-10 17:08 UTC (permalink / raw)
To: Takashi Iwai; +Cc: alsa-devel, linux-kernel
On Tue, Jan 10, 2006 at 06:00:29PM +0100, Takashi Iwai wrote:
> At Tue, 10 Jan 2006 17:44:49 +0100,
> Adrian Bunk wrote:
> >
> > SND_SUPPORT_OLD_API only has an effect if SND_PCM is set.
> >
> >
> > Signed-off-by: Adrian Bunk <bunk@stusta.de>
> >
> > --- linux-2.6.15-mm2-full/sound/core/Kconfig.old 2006-01-10 17:35:35.000000000 +0100
> > +++ linux-2.6.15-mm2-full/sound/core/Kconfig 2006-01-10 17:36:07.000000000 +0100
> > @@ -124,7 +124,7 @@
> >
> > config SND_SUPPORT_OLD_API
> > bool "Support old ALSA API"
> > - depends on SND
> > + depends on SND_PCM
> > default y
> > help
> > Say Y here to support the obsolete ALSA PCM API (ver.0.9.0 rc3
>
> Does it work? CONFIG_SND_PCM is selected by the drivers. So, it will
> be N until any drivers are selected.
It does work and "make oldconfig" handles it perfectly, but I understand
your point that it might be accidentially set to N if a user later
selects a driver in "make {menu,x}oldconfig", and that this case is most
likely better handled without my patch.
> Takashi
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [Alsa-devel] [2.6 patch] let SND_SUPPORT_OLD_API depend on SND_PCM
2006-01-10 17:08 ` Adrian Bunk
@ 2006-01-10 17:39 ` Takashi Iwai
0 siblings, 0 replies; 6+ messages in thread
From: Takashi Iwai @ 2006-01-10 17:39 UTC (permalink / raw)
To: Adrian Bunk; +Cc: alsa-devel, linux-kernel
At Tue, 10 Jan 2006 18:08:36 +0100,
Adrian Bunk wrote:
>
> On Tue, Jan 10, 2006 at 06:00:29PM +0100, Takashi Iwai wrote:
> > At Tue, 10 Jan 2006 17:44:49 +0100,
> > Adrian Bunk wrote:
> > >
> > > SND_SUPPORT_OLD_API only has an effect if SND_PCM is set.
> > >
> > >
> > > Signed-off-by: Adrian Bunk <bunk@stusta.de>
> > >
> > > --- linux-2.6.15-mm2-full/sound/core/Kconfig.old 2006-01-10 17:35:35.000000000 +0100
> > > +++ linux-2.6.15-mm2-full/sound/core/Kconfig 2006-01-10 17:36:07.000000000 +0100
> > > @@ -124,7 +124,7 @@
> > >
> > > config SND_SUPPORT_OLD_API
> > > bool "Support old ALSA API"
> > > - depends on SND
> > > + depends on SND_PCM
> > > default y
> > > help
> > > Say Y here to support the obsolete ALSA PCM API (ver.0.9.0 rc3
> >
> > Does it work? CONFIG_SND_PCM is selected by the drivers. So, it will
> > be N until any drivers are selected.
>
> It does work and "make oldconfig" handles it perfectly, but I understand
> your point that it might be accidentially set to N if a user later
> selects a driver in "make {menu,x}oldconfig", and that this case is most
> likely better handled without my patch.
Yes, exactly. IMO, it's safer to avoid this dependency check.
Takashi
^ permalink raw reply [flat|nested] 6+ messages in thread
* [2.6 patch] let SND_SUPPORT_OLD_API depend on SND_PCM
@ 2006-01-10 16:44 Adrian Bunk
0 siblings, 0 replies; 6+ messages in thread
From: Adrian Bunk @ 2006-01-10 16:44 UTC (permalink / raw)
To: perex; +Cc: alsa-devel, linux-kernel
SND_SUPPORT_OLD_API only has an effect if SND_PCM is set.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.15-mm2-full/sound/core/Kconfig.old 2006-01-10 17:35:35.000000000 +0100
+++ linux-2.6.15-mm2-full/sound/core/Kconfig 2006-01-10 17:36:07.000000000 +0100
@@ -124,7 +124,7 @@
config SND_SUPPORT_OLD_API
bool "Support old ALSA API"
- depends on SND
+ depends on SND_PCM
default y
help
Say Y here to support the obsolete ALSA PCM API (ver.0.9.0 rc3
-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems? Stop! Download the new AJAX search engine that makes
searching your log files as easy as surfing the web. DOWNLOAD SPLUNK!
http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2006-01-10 17:39 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-01-10 16:44 [2.6 patch] let SND_SUPPORT_OLD_API depend on SND_PCM Adrian Bunk
2006-01-10 17:00 ` Takashi Iwai
2006-01-10 17:00 ` [Alsa-devel] " Takashi Iwai
2006-01-10 17:08 ` Adrian Bunk
2006-01-10 17:39 ` Takashi Iwai
-- strict thread matches above, loose matches on Subject: below --
2006-01-10 16:44 Adrian Bunk
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.