From: Chris Mason <mason@suse.com>
To: Jan Kara <jack@suse.cz>
Cc: Andrew Morton <akpm@osdl.org>, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] Fix ext2 error reporting on fsync
Date: Thu, 12 Jan 2006 10:36:15 -0500 [thread overview]
Message-ID: <200601121036.16645.mason@suse.com> (raw)
In-Reply-To: <20060112142140.GA14235@atrey.karlin.mff.cuni.cz>
On Thursday 12 January 2006 09:21, Jan Kara wrote:
>
> > Hmmm, how does this work with two concurrent fsyncs on different files?
>
> Where is the problem? Different files will have different buffers in
> its private_list lists, different address_space structures etc. So they
> should not interact in any way. Or am I missing something?
>
I thought ext2 was using mark_buffer_dirty_inode for the bitmap blocks as
well. Checking again, it's only using it for the direct/indirect blocks.
So, Andrew's idea will work fine.
I suppose it's up for debate if a failure writing other metadata should fail
the fsync. I would say yes, but there are valid reasons to say no.
-chris
next prev parent reply other threads:[~2006-01-12 15:36 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-11 17:43 [PATCH] Fix ext2 error reporting on fsync Jan Kara
2006-01-12 4:24 ` Andrew Morton
2006-01-12 10:20 ` Jan Kara
2006-01-12 11:52 ` Andrew Morton
2006-01-12 13:58 ` Chris Mason
2006-01-12 14:21 ` Jan Kara
2006-01-12 15:36 ` Chris Mason [this message]
2006-01-12 16:32 ` Jan Kara
2006-01-12 14:26 ` Jan Kara
2006-01-12 20:47 ` Andrew Morton
2006-01-13 2:08 ` Chris Mason
2006-01-13 2:16 ` Andrew Morton
2006-01-18 22:46 ` Jan Kara
2006-01-18 23:06 ` Andrew Morton
2006-01-19 12:21 ` Jan Kara
2006-01-19 21:16 ` Andrew Morton
2006-01-20 13:41 ` Jan Kara
2006-01-20 21:24 ` Andrew Morton
2006-01-20 21:31 ` Andrew Morton
2006-01-20 21:33 ` Andrew Morton
2006-01-22 22:55 ` Jan Kara
2006-01-23 0:06 ` Andrew Morton
2006-01-22 22:32 ` Jan Kara
2006-01-22 23:31 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200601121036.16645.mason@suse.com \
--to=mason@suse.com \
--cc=akpm@osdl.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.