All of lore.kernel.org
 help / color / mirror / Atom feed
From: mita@miraclelinux.com (Akinobu Mita)
To: ak@suse.de, linux-kernel@vger.kernel.org
Subject: [PATCH 2/3] use usual call trace format on x86-64
Date: Mon, 16 Jan 2006 21:18:01 +0900	[thread overview]
Message-ID: <20060116121800.GC539@miraclelinux.com> (raw)
In-Reply-To: <20060116121611.GA539@miraclelinux.com>

Use print_symbol() to dump call trace.

Signed-off-by: Akinobu Mita <mita@miraclelinux.com>
----
 traps.c |   29 +++++++----------------------
 1 files changed, 7 insertions(+), 22 deletions(-)

--- 2.6-mm/arch/x86_64/kernel/traps.c.orig	2006-01-08 00:49:46.000000000 +0900
+++ 2.6-mm/arch/x86_64/kernel/traps.c	2006-01-08 00:54:07.000000000 +0900
@@ -30,6 +30,7 @@
 #include <linux/moduleparam.h>
 #include <linux/nmi.h>
 #include <linux/kprobes.h>
+#include <linux/kallsyms.h> 
 
 #include <asm/system.h>
 #include <asm/uaccess.h>
@@ -93,30 +94,14 @@ static inline void conditional_sti(struc
 
 static int kstack_depth_to_print = 10;
 
-#ifdef CONFIG_KALLSYMS
-#include <linux/kallsyms.h> 
-int printk_address(unsigned long address)
-{ 
-	unsigned long offset = 0, symsize;
-	const char *symname;
-	char *modname;
-	char *delim = ":"; 
-	char namebuf[128];
-
-	symname = kallsyms_lookup(address, &symsize, &offset, &modname, namebuf); 
-	if (!symname) 
-		return printk("[<%016lx>]", address);
-	if (!modname) 
-		modname = delim = ""; 		
-        return printk("<%016lx>{%s%s%s%s%+ld}",
-		      address,delim,modname,delim,symname,offset); 
-} 
-#else
 int printk_address(unsigned long address)
 { 
-	return printk("[<%016lx>]", address);
-} 
-#endif
+	int len;
+
+	len = printk("[<%016lx>]", address);
+	len += print_symbol(" %s", address);
+	return len;
+}
 
 static unsigned long *in_exception_stack(unsigned cpu, unsigned long stack,
 					unsigned *usedp, const char **idp)

  parent reply	other threads:[~2006-01-16 12:18 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-16 12:16 [PATCH 0/3] changes about Call Trace: Akinobu Mita
2006-01-16 12:17 ` [PATCH 1/3] makes print_symbol() return int Akinobu Mita
2006-01-16 14:16   ` Jesper Juhl
2006-01-16 14:24     ` Akinobu Mita
2006-01-16 15:18       ` Jesper Juhl
2006-01-16 12:18 ` Akinobu Mita [this message]
2006-01-16 12:22   ` [PATCH 2/3] use usual call trace format on x86-64 Andi Kleen
2006-01-16 12:32     ` Christoph Hellwig
2006-01-16 12:46       ` Andi Kleen
2006-01-16 12:18 ` [PATCH 3/3] omit symbol size field in print_symbol() Akinobu Mita
2006-01-16 12:22   ` Andi Kleen
2006-01-16 14:37   ` Arjan van de Ven
2006-01-16 15:51     ` Akinobu Mita
2006-01-17  7:06     ` Akinobu Mita
2006-01-16 12:22 ` [PATCH 0/3] changes about Call Trace: Andi Kleen
2006-01-16 13:41   ` Akinobu Mita
2006-01-16 13:41     ` Akinobu Mita
2006-01-16 13:42     ` Akinobu Mita
2006-01-16 22:22     ` Andi Kleen
2006-01-17 16:53       ` Jan Engelhardt
2006-01-17  7:05   ` Akinobu Mita

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060116121800.GC539@miraclelinux.com \
    --to=mita@miraclelinux.com \
    --cc=ak@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.