All of lore.kernel.org
 help / color / mirror / Atom feed
From: mita@miraclelinux.com (Akinobu Mita)
To: ak@suse.de, linux-kernel@vger.kernel.org
Cc: Chuck Ebbert <76306.1226@compuserve.com>,
	Christoph Hellwig <hch@infradead.org>,
	Jesper Juhl <jesper.juhl@gmail.com>,
	Arjan van de Ven <arjan@infradead.org>
Subject: [PATCH 3/4] compact print_symbol() output
Date: Tue, 17 Jan 2006 19:15:55 +0900	[thread overview]
Message-ID: <20060117101555.GD19473@miraclelinux.com> (raw)
In-Reply-To: <20060117101339.GA19473@miraclelinux.com>

- remove symbolsize field
- change offset format from hexadecimal to decimal

99.9% of the functions in my vmlinux are smaller than 10000 bytes.
Therefore call trace must be more compact.

Signed-off-by: Akinobu Mita <mita@miraclelinux.com>
----

 kallsyms.c |    7 +++----
 1 files changed, 3 insertions(+), 4 deletions(-)

--- 2.6-git/kernel/kallsyms.c.orig	2006-01-16 22:06:16.000000000 +0900
+++ 2.6-git/kernel/kallsyms.c	2006-01-16 22:09:52.000000000 +0900
@@ -237,7 +237,7 @@ int __print_symbol(const char *fmt, unsi
 	const char *name;
 	unsigned long offset, size;
 	char namebuf[KSYM_NAME_LEN+1];
-	char buffer[sizeof("%s+%#lx/%#lx [%s]") + KSYM_NAME_LEN +
+	char buffer[sizeof("%s+%ld [%s]") + KSYM_NAME_LEN +
 		    2*(BITS_PER_LONG*3/10) + MODULE_NAME_LEN + 1];
 
 	name = kallsyms_lookup(address, &size, &offset, &modname, namebuf);
@@ -246,10 +246,9 @@ int __print_symbol(const char *fmt, unsi
 		sprintf(buffer, "0x%lx", address);
 	else {
 		if (modname)
-			sprintf(buffer, "%s+%#lx/%#lx [%s]", name, offset,
-				size, modname);
+			sprintf(buffer, "%s+%ld [%s]", name, offset, modname);
 		else
-			sprintf(buffer, "%s+%#lx/%#lx", name, offset, size);
+			sprintf(buffer, "%s+%ld", name, offset);
 	}
 	return printk(fmt, buffer);
 }

  parent reply	other threads:[~2006-01-17 10:16 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-17 10:13 [PATCH 0/4] compact call trace Akinobu Mita
2006-01-17 10:14 ` [PATCH 1/4] makes print_symbol() return int Akinobu Mita
2006-01-17 10:15 ` [PATCH 2/4] x86-64: Use print_symbol() to dump call trace Akinobu Mita
2006-01-17 10:15 ` Akinobu Mita [this message]
2006-01-17 10:34   ` [PATCH 3/4] compact print_symbol() output Keith Owens
2006-01-17 10:52     ` Jesper Juhl
2006-01-17 10:58       ` Akinobu Mita
2006-01-17 11:01         ` Keith Owens
2006-01-17 11:23     ` Akinobu Mita
2006-01-17 15:01       ` Hugh Dickins
2006-01-17 15:01         ` Andi Kleen
2006-01-17 10:16 ` [PATCH 4/4] i386: print system_utsname.version in oops Akinobu Mita
2006-01-17 10:31 ` [PATCH 0/4] compact call trace Arjan van de Ven
2006-01-17 10:42   ` Keith Owens
  -- strict thread matches above, loose matches on Subject: below --
2006-01-18  3:05 [PATCH 3/4] compact print_symbol() output Chuck Ebbert
2006-01-18  3:15 ` Keith Owens
2006-01-18  3:25 ` Valdis.Kletnieks
2006-01-18  6:08 Chuck Ebbert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060117101555.GD19473@miraclelinux.com \
    --to=mita@miraclelinux.com \
    --cc=76306.1226@compuserve.com \
    --cc=ak@suse.de \
    --cc=arjan@infradead.org \
    --cc=hch@infradead.org \
    --cc=jesper.juhl@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.