From: mita@miraclelinux.com (Akinobu Mita)
To: Jesper Juhl <jesper.juhl@gmail.com>
Cc: Keith Owens <kaos@ocs.com.au>,
ak@suse.de, linux-kernel@vger.kernel.org,
Chuck Ebbert <76306.1226@compuserve.com>,
Christoph Hellwig <hch@infradead.org>,
Arjan van de Ven <arjan@infradead.org>
Subject: Re: [PATCH 3/4] compact print_symbol() output
Date: Tue, 17 Jan 2006 19:58:27 +0900 [thread overview]
Message-ID: <20060117105826.GA24488@miraclelinux.com> (raw)
In-Reply-To: <9a8748490601170252g1a89262n2745ef5bb3e1b16f@mail.gmail.com>
On Tue, Jan 17, 2006 at 11:52:19AM +0100, Jesper Juhl wrote:
> On 1/17/06, Keith Owens <kaos@ocs.com.au> wrote:
> > Akinobu Mita (on Tue, 17 Jan 2006 19:15:55 +0900) wrote:
> > >- remove symbolsize field
> > >- change offset format from hexadecimal to decimal
> >
> > That is silly. Almost every binutils tool prints offsets in hex,
> > including objdump and gdb. Printing the trace offset in decimal just
> > makes more work for users to convert back to decimal to match up with
> > all the other tools.
> >
> Agreed.
> Also, hex output is shorter and often more natural for this type of data.
>
In my vmlinux, 99.9% of the functions are smaller than 10000 bytes.
10000 == 0x2710
So. strlen("10000") == 5 < strlen("0x2710") == 6
Therefore call trace must be more compact.
next prev parent reply other threads:[~2006-01-17 10:58 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-17 10:13 [PATCH 0/4] compact call trace Akinobu Mita
2006-01-17 10:14 ` [PATCH 1/4] makes print_symbol() return int Akinobu Mita
2006-01-17 10:15 ` [PATCH 2/4] x86-64: Use print_symbol() to dump call trace Akinobu Mita
2006-01-17 10:15 ` [PATCH 3/4] compact print_symbol() output Akinobu Mita
2006-01-17 10:34 ` Keith Owens
2006-01-17 10:52 ` Jesper Juhl
2006-01-17 10:58 ` Akinobu Mita [this message]
2006-01-17 11:01 ` Keith Owens
2006-01-17 11:23 ` Akinobu Mita
2006-01-17 15:01 ` Hugh Dickins
2006-01-17 15:01 ` Andi Kleen
2006-01-17 10:16 ` [PATCH 4/4] i386: print system_utsname.version in oops Akinobu Mita
2006-01-17 10:31 ` [PATCH 0/4] compact call trace Arjan van de Ven
2006-01-17 10:42 ` Keith Owens
-- strict thread matches above, loose matches on Subject: below --
2006-01-18 3:05 [PATCH 3/4] compact print_symbol() output Chuck Ebbert
2006-01-18 3:15 ` Keith Owens
2006-01-18 3:25 ` Valdis.Kletnieks
2006-01-18 6:08 Chuck Ebbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060117105826.GA24488@miraclelinux.com \
--to=mita@miraclelinux.com \
--cc=76306.1226@compuserve.com \
--cc=ak@suse.de \
--cc=arjan@infradead.org \
--cc=hch@infradead.org \
--cc=jesper.juhl@gmail.com \
--cc=kaos@ocs.com.au \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.