From: Nick Piggin <npiggin@suse.de>
To: Linus Torvalds <torvalds@osdl.org>, Andrew Morton <akpm@osdl.org>
Cc: Nick Piggin <npiggin@suse.de>,
Linux Memory Management <linux-mm@kvack.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: [patch 6/6] mm: de-skew page refcounting
Date: Thu, 19 Jan 2006 20:23:40 +0100 (CET) [thread overview]
Message-ID: <20060119192229.11913.59043.sendpatchset@linux.site> (raw)
In-Reply-To: <20060119192131.11913.27564.sendpatchset@linux.site>
atomic_add_unless (atomic_inc_not_zero) no longer requires an offset
refcount to function correctly.
Signed-off-by: Nick Piggin <npiggin@suse.de>
Index: linux-2.6/include/linux/mm.h
===================================================================
--- linux-2.6.orig/include/linux/mm.h
+++ linux-2.6/include/linux/mm.h
@@ -294,7 +294,7 @@ struct page {
*/
static inline int put_page_testzero(struct page *page)
{
- BUG_ON(atomic_read(&page->_count) == -1);
+ BUG_ON(atomic_read(&page->_count) == 0);
return atomic_dec_and_test(&page->_count);
}
@@ -304,10 +304,10 @@ static inline int put_page_testzero(stru
*/
static inline int get_page_unless_zero(struct page *page)
{
- return atomic_add_unless(&page->_count, 1, -1);
+ return atomic_inc_not_zero(&page->_count);
}
-#define set_page_count(p,v) atomic_set(&(p)->_count, (v) - 1)
+#define set_page_count(p,v) atomic_set(&(p)->_count, (v))
#define __put_page(p) atomic_dec(&(p)->_count)
extern void FASTCALL(__page_cache_release(struct page *));
@@ -316,7 +316,7 @@ static inline int page_count(struct page
{
if (PageCompound(page))
page = (struct page *)page_private(page);
- return atomic_read(&page->_count) + 1;
+ return atomic_read(&page->_count);
}
static inline void get_page(struct page *page)
WARNING: multiple messages have this Message-ID (diff)
From: Nick Piggin <npiggin@suse.de>
To: Linus Torvalds <torvalds@osdl.org>, Andrew Morton <akpm@osdl.org>
Cc: Nick Piggin <npiggin@suse.de>,
Linux Memory Management <linux-mm@kvack.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: [patch 6/6] mm: de-skew page refcounting
Date: Thu, 19 Jan 2006 20:23:40 +0100 (CET) [thread overview]
Message-ID: <20060119192229.11913.59043.sendpatchset@linux.site> (raw)
In-Reply-To: <20060119192131.11913.27564.sendpatchset@linux.site>
atomic_add_unless (atomic_inc_not_zero) no longer requires an offset
refcount to function correctly.
Signed-off-by: Nick Piggin <npiggin@suse.de>
Index: linux-2.6/include/linux/mm.h
===================================================================
--- linux-2.6.orig/include/linux/mm.h
+++ linux-2.6/include/linux/mm.h
@@ -294,7 +294,7 @@ struct page {
*/
static inline int put_page_testzero(struct page *page)
{
- BUG_ON(atomic_read(&page->_count) == -1);
+ BUG_ON(atomic_read(&page->_count) == 0);
return atomic_dec_and_test(&page->_count);
}
@@ -304,10 +304,10 @@ static inline int put_page_testzero(stru
*/
static inline int get_page_unless_zero(struct page *page)
{
- return atomic_add_unless(&page->_count, 1, -1);
+ return atomic_inc_not_zero(&page->_count);
}
-#define set_page_count(p,v) atomic_set(&(p)->_count, (v) - 1)
+#define set_page_count(p,v) atomic_set(&(p)->_count, (v))
#define __put_page(p) atomic_dec(&(p)->_count)
extern void FASTCALL(__page_cache_release(struct page *));
@@ -316,7 +316,7 @@ static inline int page_count(struct page
{
if (PageCompound(page))
page = (struct page *)page_private(page);
- return atomic_read(&page->_count) + 1;
+ return atomic_read(&page->_count);
}
static inline void get_page(struct page *page)
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2006-01-19 19:23 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-19 19:22 [patch 0/6] mm: optimisations and page ref simplifications Nick Piggin
2006-01-19 19:22 ` Nick Piggin
2006-01-19 19:22 ` [patch 1/6] mm: never ClearPageLRU released pages Nick Piggin
2006-01-19 19:22 ` Nick Piggin
2006-01-19 19:23 ` [patch 2/6] mm: PageLRU no testset Nick Piggin
2006-01-19 19:23 ` Nick Piggin
2006-01-19 19:23 ` [patch 3/6] mm: PageActive " Nick Piggin
2006-01-19 19:23 ` Nick Piggin
2006-01-19 19:23 ` [patch 4/6] mm: less atomic ops Nick Piggin
2006-01-19 19:23 ` Nick Piggin
2006-01-19 19:23 ` [patch 5/6] mm: simplify vmscan vs release refcounting Nick Piggin
2006-01-19 19:23 ` Nick Piggin
2006-01-19 19:35 ` Linus Torvalds
2006-01-19 19:35 ` Linus Torvalds
2006-01-19 19:53 ` Nick Piggin
2006-01-19 19:53 ` Nick Piggin
2006-01-19 19:23 ` Nick Piggin [this message]
2006-01-19 19:23 ` [patch 6/6] mm: de-skew page refcounting Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060119192229.11913.59043.sendpatchset@linux.site \
--to=npiggin@suse.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.