From: Ashok Raj <ashok.raj@intel.com>
To: Ravikiran G Thirumalai <kiran@scalex86.org>
Cc: Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org, "Tolentino,
Matthew E" <matthew.e.tolentino@intel.com>,
ak@suse.de, shai@scalex86.org
Subject: Re: [bug] __meminit breaks cpu hotplug
Date: Fri, 20 Jan 2006 17:49:04 -0800 [thread overview]
Message-ID: <20060120174904.A7259@unix-os.sc.intel.com> (raw)
In-Reply-To: <20060121012709.GC3573@localhost.localdomain>; from kiran@scalex86.org on Fri, Jan 20, 2006 at 05:27:09PM -0800
On Fri, Jan 20, 2006 at 05:27:09PM -0800, Ravikiran G Thirumalai wrote:
>
>
> I hit the bug on pageset_cpuup_callback, which is obviously __cpuinit,
> but
> has been marked __meminit. Yeah .. bad patch duh!
>
> For some reason I thought all other functions marked with __meminit
> looked
> like __cpuinit candidates....while just pageset_cpuup_callback should
> be
> changed to __cpuinit
>
Sorry i missed this while posting the other patch. There are other functions
called by process_zones() from withing pageset_cpuup_callback() that
are also marked __meminit. I sent a patch just now to cover that.
but as i mentioned i still have trouble getting cpuup to work right.
cpu_down() seems to work ok so far.
--
Cheers,
Ashok Raj
- Open Source Technology Center
prev parent reply other threads:[~2006-01-21 1:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-21 0:40 [bug] __meminit breaks cpu hotplug Ravikiran G Thirumalai
2006-01-21 0:55 ` Andrew Morton
2006-01-21 1:27 ` Ravikiran G Thirumalai
2006-01-21 1:49 ` Ashok Raj [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060120174904.A7259@unix-os.sc.intel.com \
--to=ashok.raj@intel.com \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=kiran@scalex86.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.e.tolentino@intel.com \
--cc=shai@scalex86.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.