From: Ravikiran G Thirumalai <kiran@scalex86.org>
To: linux-kernel@vger.kernel.org
Cc: Andrew Morton <akpm@osdl.org>,
matthew.e.tolentino@intel.com, Andi Kleen <ak@suse.de>,
"Shai Fultheim (Shai@scalex86.org)" <shai@scalex86.org>
Subject: [bug] __meminit breaks cpu hotplug
Date: Fri, 20 Jan 2006 16:40:23 -0800 [thread overview]
Message-ID: <20060121004023.GB3573@localhost.localdomain> (raw)
Recent __meminit additions broke cpu hotplug when the kernel is configured
with HOTPLUG_CPU but not HOTPLUG_MEMORY.
Although __meminit replaced __devinit functions many places, all those functions
looked like they should have been marked with __cpuinit to begin with. That
is the reason I have changed the below to __cpuinit. I leave it to Matt if he
wants to use __devinit here instead. (Depending on where he sees __meminit
would be used.)
Signed-off-by: Ravikiran Thirumalai <kiran@scalex86.org>
Signed-off-by: Shai Fultheim <shai@scalex86.org>
Index: linux-2.6.16-rc1/include/linux/init.h
===================================================================
--- linux-2.6.16-rc1.orig/include/linux/init.h 2006-01-17 14:12:16.000000000 -0800
+++ linux-2.6.16-rc1/include/linux/init.h 2006-01-20 12:24:44.000000000 -0800
@@ -247,10 +247,10 @@ void __init parse_early_param(void);
#define __memexit
#define __memexitdata
#else
-#define __meminit __init
-#define __meminitdata __initdata
-#define __memexit __exit
-#define __memexitdata __exitdata
+#define __meminit __cpuinit
+#define __meminitdata __cpuinitdata
+#define __memexit __cpuexit
+#define __memexitdata __cpuexitdata
#endif
/* Functions marked as __devexit may be discarded at kernel link time, depending
next reply other threads:[~2006-01-21 0:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-21 0:40 Ravikiran G Thirumalai [this message]
2006-01-21 0:55 ` [bug] __meminit breaks cpu hotplug Andrew Morton
2006-01-21 1:27 ` Ravikiran G Thirumalai
2006-01-21 1:49 ` Ashok Raj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060121004023.GB3573@localhost.localdomain \
--to=kiran@scalex86.org \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.e.tolentino@intel.com \
--cc=shai@scalex86.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.