[lm-sensors] scx200_acb compilation breakage

[lm-sensors] scx200_acb compilation breakage

[Jean Delvare]

Hi Ben,

Andrew Morton is reporting scx200_acb compilation breakage on non-x86
due to the use of asm/msr.h, which only i386 and x86_64 have. This is
caused by your patch adding CS5535 support.

Now, how do we fix the problem?

First solution is to make the driver depend on X86. But are there other
architectures where this driver may be used? I'd guess not.

Second solution is to surround the CS5535 specific parts with #ifdef
X86 so that the driver can still be compiled on other architectures.

Opinions?

Thanks,
-- 
Jean Delvare

[lm-sensors] scx200_acb compilation breakage

[BGardner]

Hi Jean,

The scx200/CS5535/etc only exist with/on the Geode processor, which is
x86.
So, I think the best option is to make it depend on X86.

Thank,
Ben

> -----Original Message-----
> From: Jean Delvare [mailto:khali at linux-fr.org] 
> Sent: Friday, January 20, 2006 2:06 PM
> To: Gardner, Ben
> Cc: LM Sensors
> Subject: scx200_acb compilation breakage
> 
> Hi Ben,
> 
> Andrew Morton is reporting scx200_acb compilation breakage on non-x86
> due to the use of asm/msr.h, which only i386 and x86_64 have. This is
> caused by your patch adding CS5535 support.
> 
> Now, how do we fix the problem?
> 
> First solution is to make the driver depend on X86. But are 
> there other
> architectures where this driver may be used? I'd guess not.
> 
> Second solution is to surround the CS5535 specific parts with #ifdef
> X86 so that the driver can still be compiled on other architectures.
> 
> Opinions?
> 
> Thanks,
> -- 
> Jean Delvare
> 
> 

[lm-sensors] scx200_acb compilation breakage

[Jean Delvare]

Hi Ben,

> The scx200/CS5535/etc only exist with/on the Geode processor, which is
> x86.
> So, I think the best option is to make it depend on X86.

OK, here's a patch then:

scx200_acb is only useful on a few Geode-based systems, and won't
compile on non-x86 systems due to the lack of asm/msr.h, as reported
by Andrew Morton. Thus, we should make that driver depend on X86.

Signed-off-by: Jean Delvare <khali at linux-fr.org>
---
 drivers/i2c/busses/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-2.6.16-rc1.orig/drivers/i2c/busses/Kconfig	2006-01-20 19:50:19.000000000 +0100
+++ linux-2.6.16-rc1/drivers/i2c/busses/Kconfig	2006-01-21 09:57:55.000000000 +0100
@@ -390,7 +390,7 @@
 
 config SCx200_ACB
 	tristate "Geode ACCESS.bus support"
-	depends on I2C && PCI
+	depends on I2C && PCI && X86
 	help
 	  Enable the use of the ACCESS.bus controllers on the Geode SCx200 and
 	  SC1100 processors and the CS5535 and CS5536 Geode companion devices.

I'll post it shortly on LKML as a reply to Andrew's 2.6.16-rc1-mm2
announce.

Thanks,
-- 
Jean Delvare

[lm-sensors] scx200_acb compilation breakage

[Jean Delvare]

Hi again Ben,

> > The scx200/CS5535/etc only exist with/on the Geode processor, which is
> > x86.
> > So, I think the best option is to make it depend on X86.

I just found this proposed patch from Dave Jones:

http://lkml.org/lkml/2006/1/20/121

Basically it adds a dependency on SCX200 rather than X86. It's more
specific so I would tend to prefer it.

However, is it OK with regards to the CS5535/CS5536? Is SCX200 set for
them? If not, Dave's fix isn't acceptable. Is there something more
specific than X86 for the CS5535/CS5536 case? If there is we could make
the driver depend on (SCX200 || CS553X) or something like that. If not
we'll have to stick to X86.

Thanks,
-- 
Jean Delvare

[lm-sensors] scx200_acb compilation breakage

[Henrik Brix Andersen]

On Sun, Jan 22, 2006 at 11:42:40AM +0100, Jean Delvare wrote:
> Basically it adds a dependency on SCX200 rather than X86. It's more
> specific so I would tend to prefer it.

An alternative would be to make it depend on MGEODEGX1, but I don't
know if that covers all Geode based boards. It's what I use for my
Soekris units, though.

Regards,
Brix
-- 
Henrik Brix Andersen <brix at gentoo.org>
Gentoo Metadistribution | Mobile computing herd
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 211 bytes
Desc: not available
Url : http://lists.lm-sensors.org/pipermail/lm-sensors/attachments/20060122/8c430202/attachment.bin