* [PATCH 2.6.x] Cobalt IDE fix, take 2
@ 2006-01-23 22:33 Peter Horton
2006-01-23 23:39 ` Alan Cox
0 siblings, 1 reply; 2+ messages in thread
From: Peter Horton @ 2006-01-23 22:33 UTC (permalink / raw)
To: linux-mips; +Cc: ralf
Fix long boot delay on Cobalt scanning non-existent IDE interfaces.
P.
Index: linux.git/include/asm-mips/mach-cobalt/ide.h
===================================================================
--- /dev/null 1970-01-01 00:00:00.000000000 +0000
+++ linux.git/include/asm-mips/mach-cobalt/ide.h 2006-01-23 22:04:15.000000000 +0000
@@ -0,0 +1,8 @@
+#ifndef __ASM_COBALT_IDE_H
+#define __ASM_COBALT_IDE_H
+
+#define MAX_LEGACY_HWIFS 2
+
+#include <asm/mach-generic/ide.h>
+
+#endif
Index: linux.git/include/asm-mips/mach-generic/ide.h
===================================================================
--- linux.git.orig/include/asm-mips/mach-generic/ide.h 2006-01-23 22:04:10.000000000 +0000
+++ linux.git/include/asm-mips/mach-generic/ide.h 2006-01-23 22:30:38.000000000 +0000
@@ -28,6 +28,10 @@
# endif
#endif
+#ifndef MAX_LEGACY_HWIFS
+# define MAX_LEGACY_HWIFS 6
+#endif
+
#define IDE_ARCH_OBSOLETE_DEFAULTS
static __inline__ int ide_probe_legacy(void)
@@ -73,7 +77,7 @@
static __inline__ unsigned long ide_default_io_base(int index)
{
- if (ide_probe_legacy())
+ if (index < MAX_LEGACY_HWIFS && ide_probe_legacy())
switch (index) {
case 0:
return 0x1f0;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 2.6.x] Cobalt IDE fix, take 2
2006-01-23 22:33 [PATCH 2.6.x] Cobalt IDE fix, take 2 Peter Horton
@ 2006-01-23 23:39 ` Alan Cox
0 siblings, 0 replies; 2+ messages in thread
From: Alan Cox @ 2006-01-23 23:39 UTC (permalink / raw)
To: Peter Horton; +Cc: linux-mips, ralf
On Llu, 2006-01-23 at 22:33 +0000, Peter Horton wrote:
> Fix long boot delay on Cobalt scanning non-existent IDE interfaces.
NAK again, please just fix this properly. If you just copy the logic
from the x86 platform it will all work without #defines and other hacks
on the already wrong core code.
Alan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-01-23 23:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-01-23 22:33 [PATCH 2.6.x] Cobalt IDE fix, take 2 Peter Horton
2006-01-23 23:39 ` Alan Cox
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.