[PATCH] IP32 gbefb depth change fix

[PATCH] IP32 gbefb depth change fix

[Kaj-Michael Lang]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 241 bytes --]

Hi

The gbefb driver does not update the framebuffer layers visual
setting when depth is changed with fbset, resulting in strange
colors (very dark blue in 16-bit, almost black in 24-bit).
The attached patch fixes that.

-- 
Kaj-Michael Lang

[-- Attachment #2: Type: TEXT/PLAIN, Size: 645 bytes --]

diff --git a/drivers/video/gbefb.c b/drivers/video/gbefb.c
index d744c51..111eacb 100644
--- a/drivers/video/gbefb.c
+++ b/drivers/video/gbefb.c
@@ -656,12 +656,15 @@ static int gbefb_set_par(struct fb_info 
 	switch (bytesPerPixel) {
 	case 1:
 		SET_GBE_FIELD(WID, TYP, val, GBE_CMODE_I8);
+		info->fix.visual = FB_VISUAL_PSEUDOCOLOR;	
 		break;
 	case 2:
 		SET_GBE_FIELD(WID, TYP, val, GBE_CMODE_ARGB5);
+		info->fix.visual = FB_VISUAL_TRUECOLOR;
 		break;
 	case 4:
 		SET_GBE_FIELD(WID, TYP, val, GBE_CMODE_RGB8);
+		info->fix.visual = FB_VISUAL_TRUECOLOR;
 		break;
 	}
 	SET_GBE_FIELD(WID, BUF, val, GBE_BMODE_BOTH);

Re: [PATCH] IP32 gbefb depth change fix

[Ralf Baechle]

On Wed, Jan 25, 2006 at 03:06:53PM +0200, Kaj-Michael Lang wrote:

> The gbefb driver does not update the framebuffer layers visual
> setting when depth is changed with fbset, resulting in strange
> colors (very dark blue in 16-bit, almost black in 24-bit).
> The attached patch fixes that.

Please send to:

FRAMEBUFFER LAYER
P:      Antonino Daplas
M:      adaplas@pol.net
L:      linux-fbdev-devel@lists.sourceforge.net
W:      http://linux-fbdev.sourceforge.net/
S:      Maintained

  Ralf

Re: [PATCH] IP32 gbefb depth change fix

[Martin Michlmayr]

* Kaj-Michael Lang <milang@tal.org> [2006-01-25 15:06]:
> +		info->fix.visual = FB_VISUAL_PSEUDOCOLOR;	

Minor note: there a trailing tab at the end of this line.
-- 
Martin Michlmayr
http://www.cyrius.com/

Re: [PATCH] IP32 gbefb depth change fix

[Ralf Baechle]

On Wed, Jan 25, 2006 at 02:16:39PM +0000, Martin Michlmayr wrote:

> * Kaj-Michael Lang <milang@tal.org> [2006-01-25 15:06]:
> > +		info->fix.visual = FB_VISUAL_PSEUDOCOLOR;	
> 
> Minor note: there a trailing tab at the end of this line.

Many Linux developers use git-applymbox which has the habbit of removing
trailing whitespace.  This may cause some inconvenience for the patch
submitter because what he's pulling back is different from what was
originally submitted.

  Ralf

[PATCH] IP32 gbefb depth change fix

[Martin Michlmayr]

From: Kaj-Michael Lang <milang@tal.org>

IP32 gbefb depth change fix

The gbefb driver does not update the framebuffer layers visual setting
when depth is changed with fbset, resulting in strange colors (very
dark blue in 16-bit, almost black in 24-bit).

Signed-off-by: Kaj-Michael Lang <milang@tal.org>
Signed-off-by: Martin Michlmayr <tbm@cyrius.com>

---

 gbefb.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

--- a/drivers/video/gbefb.c
+++ b/drivers/video/gbefb.c
@@ -656,12 +656,15 @@ static int gbefb_set_par(struct fb_info 
 	switch (bytesPerPixel) {
 	case 1:
 		SET_GBE_FIELD(WID, TYP, val, GBE_CMODE_I8);
+		info->fix.visual = FB_VISUAL_PSEUDOCOLOR;
 		break;
 	case 2:
 		SET_GBE_FIELD(WID, TYP, val, GBE_CMODE_ARGB5);
+		info->fix.visual = FB_VISUAL_TRUECOLOR;
 		break;
 	case 4:
 		SET_GBE_FIELD(WID, TYP, val, GBE_CMODE_RGB8);
+		info->fix.visual = FB_VISUAL_TRUECOLOR;
 		break;
 	}
 	SET_GBE_FIELD(WID, BUF, val, GBE_BMODE_BOTH);

-- 
Martin Michlmayr
http://www.cyrius.com/


-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=103432&bid=230486&dat=121642