All of lore.kernel.org
 help / color / mirror / Atom feed
From: Akinobu Mita <mita@miraclelinux.com>
To: linux-kernel@vger.kernel.org
Cc: Chris Zankel <chris@zankel.net>, Keith Owens <kaos@sgi.com>,
	Akinobu Mita <mita@miraclelinux.com>
Subject: [patch 05/44] generic {,test_and_}{set,clear,change}_bit()
Date: Wed, 01 Feb 2006 18:02:29 +0900	[thread overview]
Message-ID: <20060201090322.252374000@localhost.localdomain> (raw)
In-Reply-To: 20060201090224.536581000@localhost.localdomain

[-- Attachment #1: atomic-bitops.patch --]
[-- Type: text/plain, Size: 6866 bytes --]

This patch introduces the C-language equivalents of the functions below:

void set_bit(int nr, volatile unsigned long *addr);
void clear_bit(int nr, volatile unsigned long *addr);
void change_bit(int nr, volatile unsigned long *addr);
int test_and_set_bit(int nr, volatile unsigned long *addr);
int test_and_clear_bit(int nr, volatile unsigned long *addr);
int test_and_change_bit(int nr, volatile unsigned long *addr);

In include/asm-generic/bitops/atomic.h

This code largely copied from:

include/asm-powerpc/bitops.h
include/asm-parisc/bitops.h
include/asm-parisc/atomic.h

Signed-off-by: Akinobu Mita <mita@miraclelinux.com>
 include/asm-generic/bitops/atomic.h |  191 ++++++++++++++++++++++++++++++++++++
 1 files changed, 191 insertions(+)

Index: 2.6-git/include/asm-generic/bitops/atomic.h
===================================================================
--- /dev/null
+++ 2.6-git/include/asm-generic/bitops/atomic.h
@@ -0,0 +1,191 @@
+#ifndef _ASM_GENERIC_BITOPS_ATOMIC_H_
+#define _ASM_GENERIC_BITOPS_ATOMIC_H_
+
+#include <asm/types.h>
+
+#define BITOP_MASK(nr)		(1UL << ((nr) % BITS_PER_LONG))
+#define BITOP_WORD(nr)		((nr) / BITS_PER_LONG)
+
+#ifdef CONFIG_SMP
+#include <asm/spinlock.h>
+#include <asm/cache.h>		/* we use L1_CACHE_BYTES */
+
+/* Use an array of spinlocks for our atomic_ts.
+ * Hash function to index into a different SPINLOCK.
+ * Since "a" is usually an address, use one spinlock per cacheline.
+ */
+#  define ATOMIC_HASH_SIZE 4
+#  define ATOMIC_HASH(a) (&(__atomic_hash[ (((unsigned long) a)/L1_CACHE_BYTES) & (ATOMIC_HASH_SIZE-1) ]))
+
+extern raw_spinlock_t __atomic_hash[ATOMIC_HASH_SIZE] __lock_aligned;
+
+/* Can't use raw_spin_lock_irq because of #include problems, so
+ * this is the substitute */
+#define _atomic_spin_lock_irqsave(l,f) do {	\
+	raw_spinlock_t *s = ATOMIC_HASH(l);	\
+	local_irq_save(f);			\
+	__raw_spin_lock(s);			\
+} while(0)
+
+#define _atomic_spin_unlock_irqrestore(l,f) do {	\
+	raw_spinlock_t *s = ATOMIC_HASH(l);		\
+	__raw_spin_unlock(s);				\
+	local_irq_restore(f);				\
+} while(0)
+
+
+#else
+#  define _atomic_spin_lock_irqsave(l,f) do { local_irq_save(f); } while (0)
+#  define _atomic_spin_unlock_irqrestore(l,f) do { local_irq_restore(f); } while (0)
+#endif
+
+/*
+ * NMI events can occur at any time, including when interrupts have been
+ * disabled by *_irqsave().  So you can get NMI events occurring while a
+ * *_bit fucntion is holding a spin lock.  If the NMI handler also wants
+ * to do bit manipulation (and they do) then you can get a deadlock
+ * between the original caller of *_bit() and the NMI handler.
+ *
+ * by Keith Owens
+ */
+
+/**
+ * set_bit - Atomically set a bit in memory
+ * @nr: the bit to set
+ * @addr: the address to start counting from
+ *
+ * This function is atomic and may not be reordered.  See __set_bit()
+ * if you do not require the atomic guarantees.
+ *
+ * Note: there are no guarantees that this function will not be reordered
+ * on non x86 architectures, so if you are writting portable code,
+ * make sure not to rely on its reordering guarantees.
+ *
+ * Note that @nr may be almost arbitrarily large; this function is not
+ * restricted to acting on a single-word quantity.
+ */
+static __inline__ void set_bit(int nr, volatile unsigned long *addr)
+{
+	unsigned long mask = BITOP_MASK(nr);
+	unsigned long *p = ((unsigned long *)addr) + BITOP_WORD(nr);
+	unsigned long flags;
+
+	_atomic_spin_lock_irqsave(p, flags);
+	*p  |= mask;
+	_atomic_spin_unlock_irqrestore(p, flags);
+}
+
+/**
+ * clear_bit - Clears a bit in memory
+ * @nr: Bit to clear
+ * @addr: Address to start counting from
+ *
+ * clear_bit() is atomic and may not be reordered.  However, it does
+ * not contain a memory barrier, so if it is used for locking purposes,
+ * you should call smp_mb__before_clear_bit() and/or smp_mb__after_clear_bit()
+ * in order to ensure changes are visible on other processors.
+ */
+static __inline__ void clear_bit(int nr, volatile unsigned long *addr)
+{
+	unsigned long mask = BITOP_MASK(nr);
+	unsigned long *p = ((unsigned long *)addr) + BITOP_WORD(nr);
+	unsigned long flags;
+
+	_atomic_spin_lock_irqsave(p, flags);
+	*p &= ~mask;
+	_atomic_spin_unlock_irqrestore(p, flags);
+}
+
+/**
+ * change_bit - Toggle a bit in memory
+ * @nr: Bit to change
+ * @addr: Address to start counting from
+ *
+ * change_bit() is atomic and may not be reordered. It may be
+ * reordered on other architectures than x86.
+ * Note that @nr may be almost arbitrarily large; this function is not
+ * restricted to acting on a single-word quantity.
+ */
+static __inline__ void change_bit(int nr, volatile unsigned long *addr)
+{
+	unsigned long mask = BITOP_MASK(nr);
+	unsigned long *p = ((unsigned long *)addr) + BITOP_WORD(nr);
+	unsigned long flags;
+
+	_atomic_spin_lock_irqsave(p, flags);
+	*p ^= mask;
+	_atomic_spin_unlock_irqrestore(p, flags);
+}
+
+/**
+ * test_and_set_bit - Set a bit and return its old value
+ * @nr: Bit to set
+ * @addr: Address to count from
+ *
+ * This operation is atomic and cannot be reordered.  
+ * It may be reordered on other architectures than x86.
+ * It also implies a memory barrier.
+ */
+static __inline__ int test_and_set_bit(int nr, volatile unsigned long *addr)
+{
+	unsigned long mask = BITOP_MASK(nr);
+	unsigned long *p = ((unsigned long *)addr) + BITOP_WORD(nr);
+	unsigned long old;
+	unsigned long flags;
+
+	_atomic_spin_lock_irqsave(p, flags);
+	old = *p;
+	*p = old | mask;
+	_atomic_spin_unlock_irqrestore(p, flags);
+
+	return (old & mask) != 0;
+}
+
+/**
+ * test_and_clear_bit - Clear a bit and return its old value
+ * @nr: Bit to clear
+ * @addr: Address to count from
+ *
+ * This operation is atomic and cannot be reordered.
+ * It can be reorderdered on other architectures other than x86.
+ * It also implies a memory barrier.
+ */
+static __inline__ int test_and_clear_bit(int nr, volatile unsigned long *addr)
+{
+	unsigned long mask = BITOP_MASK(nr);
+	unsigned long *p = ((unsigned long *)addr) + BITOP_WORD(nr);
+	unsigned long old;
+	unsigned long flags;
+
+	_atomic_spin_lock_irqsave(p, flags);
+	old = *p;
+	*p = old & ~mask;
+	_atomic_spin_unlock_irqrestore(p, flags);
+
+	return (old & mask) != 0;
+}
+
+/**
+ * test_and_change_bit - Change a bit and return its old value
+ * @nr: Bit to change
+ * @addr: Address to count from
+ *
+ * This operation is atomic and cannot be reordered.  
+ * It also implies a memory barrier.
+ */
+static __inline__ int test_and_change_bit(int nr, volatile unsigned long *addr)
+{
+	unsigned long mask = BITOP_MASK(nr);
+	unsigned long *p = ((unsigned long *)addr) + BITOP_WORD(nr);
+	unsigned long old;
+	unsigned long flags;
+
+	_atomic_spin_lock_irqsave(p, flags);
+	old = *p;
+	*p = old ^ mask;
+	_atomic_spin_unlock_irqrestore(p, flags);
+
+	return (old & mask) != 0;
+}
+
+#endif /* _ASM_GENERIC_BITOPS_ATOMIC_H */

--

  parent reply	other threads:[~2006-02-01  9:13 UTC|newest]

Thread overview: 145+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-01  9:02 [patch 00/44] generic bitops Akinobu Mita
2006-02-01  9:02 ` [patch 01/44] ia64: use cpu_set() instead of __set_bit() Akinobu Mita
2006-02-01  9:02   ` Akinobu Mita
2006-02-01  9:02 ` [patch 02/44] parisc: add ()-pair in __ffz() macro Akinobu Mita
2006-02-01  9:02 ` [patch 03/44] cris: remove unnecessary local_irq_restore() Akinobu Mita
2006-02-01  9:02 ` [patch 04/44] use non atomic operations for minix_*_bit() and ext2_*_bit() Akinobu Mita
2006-02-01  9:02   ` Akinobu Mita
2006-02-01  9:02   ` Akinobu Mita
2006-02-01  9:02   ` Akinobu Mita
2006-02-01  9:02 ` Akinobu Mita [this message]
2006-02-03  9:55   ` [patch 05/44] generic {,test_and_}{set,clear,change}_bit() Martin Waitz
2006-02-06 23:07     ` Russell King
2006-02-01  9:02 ` [patch 06/44] generic __{,test_and_}{set,clear,change}_bit() and test_bit() Akinobu Mita
2006-02-01  9:02   ` [patch 06/44] generic __{, test_and_}{set, clear, change}_bit() " Akinobu Mita
2006-02-01  9:02   ` [patch 06/44] generic __{,test_and_}{set,clear,change}_bit() " Akinobu Mita
2006-02-01  9:02 ` [patch 07/44] generic __ffs() Akinobu Mita
2006-02-01  9:02   ` Akinobu Mita
2006-02-01  9:02 ` [patch 08/44] generic ffz() Akinobu Mita
2006-02-01  9:02   ` Akinobu Mita
2006-02-01  9:02 ` [patch 09/44] generic fls() Akinobu Mita
2006-02-01  9:02   ` Akinobu Mita
2006-02-01  9:02 ` [patch 10/44] generic fls64() Akinobu Mita
2006-02-01  9:02   ` Akinobu Mita
2006-02-01  9:02   ` Akinobu Mita
2006-02-01  9:02   ` Akinobu Mita
2006-02-01  9:02   ` Akinobu Mita
2006-02-02 15:05   ` Rune Torgersen
2006-02-02 15:05     ` Rune Torgersen
2006-02-02 15:05     ` Rune Torgersen
2006-02-02 15:05     ` Rune Torgersen
2006-02-02 15:05     ` Rune Torgersen
2006-02-02 15:05     ` Rune Torgersen
2006-02-03  1:27     ` [PATCH] fix generic_fls64() Akinobu Mita
2006-02-03  1:27       ` Akinobu Mita
2006-02-03  1:27       ` Akinobu Mita
2006-02-03  1:27       ` Akinobu Mita
2006-02-03  1:27       ` Akinobu Mita
2006-02-01  9:02 ` [patch 11/44] generic find_{next,first}{,_zero}_bit() Akinobu Mita
2006-02-01  9:02   ` Akinobu Mita
2006-02-06 10:26   ` David Howells
2006-02-07  2:02     ` Akinobu Mita
2006-02-07  2:02       ` Akinobu Mita
2006-02-01  9:02 ` [patch 12/44] generic sched_find_first_bit() Akinobu Mita
2006-02-01  9:02   ` Akinobu Mita
2006-02-01  9:02   ` Akinobu Mita
2006-02-01  9:02   ` Akinobu Mita
2006-02-01  9:02   ` Akinobu Mita
2006-02-03  3:58   ` [parisc-linux] " Grant Grundler
2006-02-03  3:58   ` Grant Grundler
2006-02-03  3:58     ` Grant Grundler
2006-02-03  3:58     ` Grant Grundler
2006-02-03  3:58     ` Grant Grundler
2006-02-03  3:58     ` Grant Grundler
2006-02-01  9:02 ` [patch 13/44] generic ffs() Akinobu Mita
2006-02-01  9:02   ` Akinobu Mita
2006-02-01  9:02 ` [patch 14/44] generic hweight{64,32,16,8}() Akinobu Mita
2006-02-01  9:02   ` Akinobu Mita
2006-02-01  9:02   ` Akinobu Mita
2006-02-01  9:02   ` Akinobu Mita
2006-02-01  9:02   ` Akinobu Mita
2006-02-01  9:06   ` Andi Kleen
2006-02-01  9:06     ` Andi Kleen
2006-02-01  9:06     ` Andi Kleen
2006-02-01  9:06     ` Andi Kleen
2006-02-01  9:06     ` Andi Kleen
2006-02-01  9:26     ` Michael Tokarev
2006-02-01  9:26       ` Michael Tokarev
2006-02-01  9:26       ` Michael Tokarev
2006-02-01  9:26       ` Michael Tokarev
2006-02-01  9:26       ` Michael Tokarev
2006-02-01 10:24       ` Andi Kleen
2006-02-01 10:24         ` Andi Kleen
2006-02-01 10:24         ` Andi Kleen
2006-02-01 10:24         ` Andi Kleen
2006-02-01 10:24         ` Andi Kleen
2006-02-02 12:50         ` Akinobu Mita
2006-02-02 12:50           ` Akinobu Mita
2006-02-02 12:50           ` Akinobu Mita
2006-02-02 12:50           ` Akinobu Mita
2006-02-02 12:50           ` Akinobu Mita
2006-02-09  5:55           ` [PATCH] alpha: remove __alpha_cix__ and __alpha_fix__ Akinobu Mita
2006-02-09 19:12             ` Richard Henderson
2006-02-10  5:40               ` Akinobu Mita
2006-02-02  1:26   ` [patch 14/44] generic hweight{64,32,16,8}() Gabriel Paubert
2006-02-02  1:26     ` Gabriel Paubert
2006-02-02  1:26     ` Gabriel Paubert
2006-02-06 11:52     ` Akinobu Mita
2006-02-06 11:52       ` Akinobu Mita
2006-02-06 11:52       ` Akinobu Mita
2006-02-03  8:31   ` Ulrich Eckhardt
2006-02-03  8:31     ` Ulrich Eckhardt
2006-02-03  8:31     ` Ulrich Eckhardt
2006-02-03  8:31     ` Ulrich Eckhardt
2006-02-03  8:31     ` Ulrich Eckhardt
2006-02-01  9:02 ` [patch 15/44] generic ext2_{set,clear,test,find_first_zero,find_next_zero}_bit() Akinobu Mita
2006-02-01  9:02   ` Akinobu Mita
2006-02-01  9:02   ` Akinobu Mita
2006-02-01  9:02   ` Akinobu Mita
2006-02-01 11:27   ` Roman Zippel
2006-02-01 11:27     ` Roman Zippel
2006-02-06 11:47     ` Akinobu Mita
2006-02-06 11:47       ` Akinobu Mita
2006-02-08 10:41     ` Akinobu Mita
2006-02-08 10:41       ` Akinobu Mita
2006-02-01  9:02 ` [patch 16/44] generic ext2_{set,clear}_bit_atomic() Akinobu Mita
2006-02-01  9:02   ` Akinobu Mita
2006-02-01  9:02 ` [patch 17/44] generic minix_{test,set,test_and_clear,test,find_first_zero}_bit() Akinobu Mita
2006-02-01  9:02   ` Akinobu Mita
2006-02-01  9:02 ` [patch 18/44] alpha: use generic bitops Akinobu Mita
2006-02-01  9:02 ` [patch 19/44] arm: " Akinobu Mita
2006-02-01  9:02 ` [patch 20/44] arm26: " Akinobu Mita
2006-02-01  9:02 ` [patch 21/44] cris: " Akinobu Mita
2006-02-01  9:02 ` [patch 22/44] frv: " Akinobu Mita
2006-02-01  9:02 ` [patch 23/44] h8300: " Akinobu Mita
2006-02-01  9:02 ` [patch 24/44] i386: " Akinobu Mita
2006-02-01  9:02 ` [patch 25/44] ia64: " Akinobu Mita
2006-02-01  9:02   ` Akinobu Mita
2006-02-01  9:02 ` [patch 26/44] m32r: " Akinobu Mita
2006-02-01  9:02 ` [patch 27/44] m68k: " Akinobu Mita
2006-02-01  9:02 ` [patch 28/44] m68knommu: " Akinobu Mita
2006-02-01  9:02 ` [patch 29/44] mips: " Akinobu Mita
2006-02-01  9:02 ` [patch 30/44] parisc: " Akinobu Mita
2006-02-01  9:02 ` [patch 31/44] powerpc: " Akinobu Mita
2006-02-01  9:02   ` Akinobu Mita
2006-02-01  9:02 ` [patch 32/44] s390: " Akinobu Mita
2006-02-01  9:02 ` [patch 33/44] sh: " Akinobu Mita
2006-02-01  9:02 ` [patch 34/44] sh64: " Akinobu Mita
2006-02-01  9:02 ` [patch 35/44] sparc: " Akinobu Mita
2006-02-01  9:02   ` Akinobu Mita
2006-02-01  9:03 ` [patch 36/44] sparc64: " Akinobu Mita
2006-02-01  9:03   ` Akinobu Mita
2006-02-01  9:03 ` [patch 37/44] v850: " Akinobu Mita
2006-02-01  9:03 ` [patch 38/44] x86_64: " Akinobu Mita
2006-02-01  9:03 ` [patch 39/44] xtensa: " Akinobu Mita
2006-02-01  9:03 ` [patch 40/44] update include/asm-generic/bitops.h Akinobu Mita
2006-02-01  9:03 ` [patch 41/44] make thread_info.flags an unsigned long Akinobu Mita
2006-02-01  9:03   ` Akinobu Mita
2006-02-01 18:17   ` Luck, Tony
2006-02-01 18:17     ` Luck, Tony
2006-02-02  1:37     ` Akinobu Mita
2006-02-02  1:37       ` Akinobu Mita
2006-02-01  9:03 ` [patch 42/44] ia64: make partial_page.bitmap " Akinobu Mita
2006-02-01  9:03   ` Akinobu Mita
2006-02-01  9:03 ` [patch 43/44] ntfs: remove generic_ffs() Akinobu Mita
2006-02-01  9:03 ` [patch 44/44] remove unused generic bitops in include/linux/bitops.h Akinobu Mita

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060201090322.252374000@localhost.localdomain \
    --to=mita@miraclelinux.com \
    --cc=chris@zankel.net \
    --cc=kaos@sgi.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.