[KJ] [PATCH] Adding MODULE_VERSION()

[KJ] [PATCH] Adding MODULE_VERSION()

[Matthew Martin]

[-- Attachment #1.1: Type: text/plain, Size: 720 bytes --]

I saw this on the TODO list and thought I'd try it. It said to add
MODULE_VERSION() to modules.  Am I doing this right?

--- /home/matthew/linux-2.6.15.2/drivers/usb/storage/usb.c    2006-02-03
14:31:09.000000000 -0600
+++ /home/matthew/src/linux-2.6.15.2/drivers/usb/storage/usb.c    2006-01-31
00:25:07.000000000 -0600
@@ -95,13 +95,10 @@
 #include "onetouch.h"
 #endif

-#define DRV_VERSION "1.75"
-
 /* Some informational data */
 MODULE_AUTHOR("Matthew Dharm <mdharm-usb@one-eyed-alien.net>");
 MODULE_DESCRIPTION("USB Mass Storage driver for Linux");
 MODULE_LICENSE("GPL");
-MODULE_VERSION(DRV_VERSION);

 static unsigned int delay_use = 5;
 module_param(delay_use, uint, S_IRUGO | S_IWUSR);

[-- Attachment #1.2: Type: text/html, Size: 1101 bytes --]

[-- Attachment #2: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [KJ] [PATCH] Adding MODULE_VERSION()

[Nishanth Aravamudan]

[-- Attachment #1: Type: text/plain, Size: 434 bytes --]

On 03.02.2006 [15:16:24 -0600], Matthew Martin wrote:
> I saw this on the TODO list and thought I'd try it. It said to add
> MODULE_VERSION() to modules.  Am I doing this right?
> 
> --- /home/matthew/linux-2.6.15.2/drivers/usb/storage/usb.c    2006-02-03
> 14:31:09.000000000 -0600
> +++ /home/matthew/src/linux-2.6.15.2/drivers/usb/storage/usb.c    2006-01-31
> 00:25:07.000000000 -0600

Your patch is line-wrapped :(

Thanks,
Nish

[-- Attachment #2: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [KJ] [PATCH] Adding MODULE_VERSION()

[Randy.Dunlap]

[-- Attachment #1: Type: text/plain, Size: 610 bytes --]

On Fri, 3 Feb 2006 18:14:25 -0800 Nishanth Aravamudan wrote:

> On 03.02.2006 [15:16:24 -0600], Matthew Martin wrote:
> > I saw this on the TODO list and thought I'd try it. It said to add
> > MODULE_VERSION() to modules.  Am I doing this right?
> > 
> > --- /home/matthew/linux-2.6.15.2/drivers/usb/storage/usb.c    2006-02-03
> > 14:31:09.000000000 -0600
> > +++ /home/matthew/src/linux-2.6.15.2/drivers/usb/storage/usb.c    2006-01-31
> > 00:25:07.000000000 -0600
> 
> Your patch is line-wrapped :(

It also looked to me like it was reversed...
and the filenames need to begin with linux-x.y.z/

---
~Randy

[-- Attachment #2: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors