All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] gdth: don't map zero-length requests
@ 2006-02-05 15:36 Christoph Hellwig
  2006-02-05 18:43 ` Jens Axboe
  0 siblings, 1 reply; 3+ messages in thread
From: Christoph Hellwig @ 2006-02-05 15:36 UTC (permalink / raw)
  To: jejb; +Cc: linux-scsi, axboe

From: Jenx Axboe <axboe@suse.de>

Don't map zero-length requests in gdth, zome architectures don't like
that in their dma mapping routines.

[ I'm pretty sure Jens posted this before, but for some reason it got
  forgotten  --hch ]


Index: linux-2.6/drivers/scsi/gdth.c
===================================================================
--- linux-2.6.orig/drivers/scsi/gdth.c	2006-01-16 16:19:38.000000000 +0100
+++ linux-2.6/drivers/scsi/gdth.c	2006-02-05 16:34:12.000000000 +0100
@@ -2816,7 +2816,7 @@
             }
 #endif
 
-        } else {
+        } else if (scp->request_bufflen) {
             scp->SCp.Status = GDTH_MAP_SINGLE;
             scp->SCp.Message = (read_write == 1 ? 
                 PCI_DMA_TODEVICE : PCI_DMA_FROMDEVICE);

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] gdth: don't map zero-length requests
  2006-02-05 15:36 [PATCH] gdth: don't map zero-length requests Christoph Hellwig
@ 2006-02-05 18:43 ` Jens Axboe
  2006-02-05 20:08   ` James Bottomley
  0 siblings, 1 reply; 3+ messages in thread
From: Jens Axboe @ 2006-02-05 18:43 UTC (permalink / raw)
  To: Christoph Hellwig; +Cc: jejb, linux-scsi

On Sun, Feb 05 2006, Christoph Hellwig wrote:
> From: Jenx Axboe <axboe@suse.de>
> 
> Don't map zero-length requests in gdth, zome architectures don't like
> that in their dma mapping routines.
> 
> [ I'm pretty sure Jens posted this before, but for some reason it got
>   forgotten  --hch ]

Thanks for reposting Christoph, James can you please pick this up?


-- 
Jens Axboe


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] gdth: don't map zero-length requests
  2006-02-05 18:43 ` Jens Axboe
@ 2006-02-05 20:08   ` James Bottomley
  0 siblings, 0 replies; 3+ messages in thread
From: James Bottomley @ 2006-02-05 20:08 UTC (permalink / raw)
  To: Jens Axboe; +Cc: Christoph Hellwig, jejb, linux-scsi

On Sun, 2006-02-05 at 19:43 +0100, Jens Axboe wrote:
> Thanks for reposting Christoph, James can you please pick this up?

Got it in scsi-rc-fixes-2.6

James



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2006-02-05 20:08 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-02-05 15:36 [PATCH] gdth: don't map zero-length requests Christoph Hellwig
2006-02-05 18:43 ` Jens Axboe
2006-02-05 20:08   ` James Bottomley

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.