From: Con Kolivas <kernel@kolivas.org>
To: Andrew Morton <akpm@osdl.org>
Cc: nickpiggin@yahoo.com.au, linux-mm@kvack.org, ck@vds.kolivas.org,
pj@sgi.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: Implement Swap Prefetching v24
Date: Sat, 11 Feb 2006 12:48:15 +1100 [thread overview]
Message-ID: <200602111248.16067.kernel@kolivas.org> (raw)
In-Reply-To: <200602110347.43121.kernel@kolivas.org>
On Saturday 11 February 2006 03:47, Con Kolivas wrote:
> Try again. Tackled everything I could think of mentioned and more.
Hrm BUG..
This version appears to work fine with the pages being added to the tail of
the LRU, however there's a problem with the custom lru_cache_add_tail
function. I end up hitting a bug at:
if (!TestClearPageLRU(page))
BUG();
in isolate_lru_pages called from shrink_zone, find_busiest_group,
shrink_slab... ultimately from kswapd.
Just looking at the lru_cache_add function I note that my lru_cache_add_tail
function is missing a page_cache_get on the page before adding it to the LRU.
I'm guessing this is wrong.
Cheers,
Con
P.S. Sorry if this thread is getting long winded; there's a record amount of
noise on lkml already :(
WARNING: multiple messages have this Message-ID (diff)
From: Con Kolivas <kernel@kolivas.org>
To: Andrew Morton <akpm@osdl.org>
Cc: nickpiggin@yahoo.com.au, linux-mm@kvack.org, ck@vds.kolivas.org,
pj@sgi.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: Implement Swap Prefetching v24
Date: Sat, 11 Feb 2006 12:48:15 +1100 [thread overview]
Message-ID: <200602111248.16067.kernel@kolivas.org> (raw)
In-Reply-To: <200602110347.43121.kernel@kolivas.org>
On Saturday 11 February 2006 03:47, Con Kolivas wrote:
> Try again. Tackled everything I could think of mentioned and more.
Hrm BUG..
This version appears to work fine with the pages being added to the tail of
the LRU, however there's a problem with the custom lru_cache_add_tail
function. I end up hitting a bug at:
if (!TestClearPageLRU(page))
BUG();
in isolate_lru_pages called from shrink_zone, find_busiest_group,
shrink_slab... ultimately from kswapd.
Just looking at the lru_cache_add function I note that my lru_cache_add_tail
function is missing a page_cache_get on the page before adding it to the LRU.
I'm guessing this is wrong.
Cheers,
Con
P.S. Sorry if this thread is getting long winded; there's a record amount of
noise on lkml already :(
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2006-02-11 1:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-10 16:47 [PATCH] mm: Implement Swap Prefetching v24 Con Kolivas
2006-02-10 16:47 ` Con Kolivas
2006-02-11 1:48 ` Con Kolivas [this message]
2006-02-11 1:48 ` Con Kolivas
2006-02-11 11:16 ` [ck] " Con Kolivas
2006-02-11 11:16 ` Con Kolivas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200602111248.16067.kernel@kolivas.org \
--to=kernel@kolivas.org \
--cc=akpm@osdl.org \
--cc=ck@vds.kolivas.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nickpiggin@yahoo.com.au \
--cc=pj@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.