All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: Roman Zippel <zippel@linux-m68k.org>
Cc: mingo@elte.hu, tglx@linutronix.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 02/13] hrtimer: remove useless const
Date: Mon, 13 Feb 2006 04:30:38 -0800	[thread overview]
Message-ID: <20060213043038.25a49dd0.akpm@osdl.org> (raw)
In-Reply-To: <Pine.LNX.4.61.0602131315150.30994@scrub.home>

Roman Zippel <zippel@linux-m68k.org> wrote:
>
> Hi,
> 
> On Mon, 13 Feb 2006, Andrew Morton wrote:
> 
> > Ingo Molnar <mingo@elte.hu> wrote:
> > >
> > > your patch makes code larger on gcc3.
> > 
> > By 120 bytes here.  I dropped the patch.
> 
> Is this really worth it? This _is_ a compiler problem, are we going to add 
> now const everywhere to work around a (small) compiler problem, which is 
> already fixed in newer versions?
> 

Can't say I care a lot, but there doesn't seem much point in giving away
the consts now we have them, if it just produces worse code.

const arguments to functions are pretty useful for code readability and
maintainability too, if you use them consistently.


  reply	other threads:[~2006-02-13 12:31 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-13  1:09 [PATCH 02/13] hrtimer: remove useless const Roman Zippel
2006-02-13 11:28 ` Thomas Gleixner
2006-02-13 11:38   ` Roman Zippel
2006-02-13 11:46     ` Ingo Molnar
2006-02-13 11:53       ` Andrew Morton
2006-02-13 12:18         ` Roman Zippel
2006-02-13 12:30           ` Andrew Morton [this message]
2006-02-13 12:50             ` Roman Zippel
2006-02-13 19:52               ` Andrew Morton
2006-02-13 19:59                 ` Ingo Molnar
2006-02-13 20:03                 ` linux-os (Dick Johnson)
2006-02-13 21:21                   ` Andrew Morton
2006-02-13 21:57                 ` Roman Zippel
2006-02-13 12:09       ` Roman Zippel
2006-02-13 12:26       ` Roman Zippel
2006-02-13 15:54       ` Roman Zippel
2006-02-13 20:35         ` Andrew Morton
2006-02-13 22:01           ` Roman Zippel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060213043038.25a49dd0.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    --cc=zippel@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.