Re: [PATCH 02/13] hrtimer: remove useless const

[Ingo Molnar <mingo@elte.hu>]

* Andrew Morton <akpm@osdl.org> wrote:

> Roman Zippel <zippel@linux-m68k.org> wrote:
> >
> > On Mon, 13 Feb 2006, Andrew Morton wrote:
> > 
> >  > const arguments to functions are pretty useful for code readability and
> >  > maintainability too, if you use them consistently.
> > 
> >  I could understand that argument, if gcc would warn about it in any way.
> 
> It does.  If a function tries to modify a formal argument which was 
> marked const you'll get a warning.
> 
> We're talking about different things here.  My point is that it is 
> perverted and evil for a function to modify its own args (unless it's 
> very small and simple), and a const declaration is a useful way for a 
> maintenance programmer to be assured that nobody has done perverted 
> and evil things to a function.

good point. I dont think it's "evil" (or as Roman has put it, "bogus") 
in any way, and it should be up to the authors of the code to decide one 
way or another. [An added bonus for me is that in my editor the 'const' 
keyword is color highlighted, so const args are visually separate from 
non-const arguments]

	Ingo