All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kyler Laird <kyler-keyword-lkml00.e701c2@lairds.com>
To: linux-kernel@vger.kernel.org
Subject: drivers/media/video/saa7115.c misreports max. value of contrast and saturation
Date: Wed, 15 Feb 2006 00:19:08 -0500	[thread overview]
Message-ID: <20060215051908.GF13033@snout> (raw)

For changes to V4L2_CID_CONTRAST and V4L2_CID_SATURATION, the value is
checked by "if (ctrl->value < 0 || ctrl->value > 127)" yet the maximum
value in v4l2_queryctrl is set to 255 for both of these items.  This
means that programs (like MythTV) which set the contrast and saturation
to the midvalue (127) get *full* contrast and saturation.  (It's not
pretty.)

Setting the maximum values to 127 solves this problem.

Please copy me on responses.

Thank you.

--kyler


             reply	other threads:[~2006-02-15  5:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-15  5:19 Kyler Laird [this message]
2006-03-08 21:19 ` drivers/media/video/saa7115.c misreports max. value of contrast and saturation Adrian Bunk
2006-03-08 21:42   ` [v4l-dvb-maintainer] " Hans Verkuil
2006-03-08 22:47   ` Mauro Carvalho Chehab
2006-03-08 23:46     ` Adrian Bunk
2006-03-09  0:21       ` Mauro Carvalho Chehab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060215051908.GF13033@snout \
    --to=kyler-keyword-lkml00.e701c2@lairds.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.