From: Adrian Bunk <bunk@stusta.de>
To: Kyler Laird <kyler-keyword-lkml00.e701c2@lairds.com>,
mchehab@infradead.org
Cc: linux-kernel@vger.kernel.org, v4l-dvb-maintainer@linuxtv.org
Subject: Re: drivers/media/video/saa7115.c misreports max. value of contrast and saturation
Date: Wed, 8 Mar 2006 22:19:00 +0100 [thread overview]
Message-ID: <20060308211900.GM4006@stusta.de> (raw)
In-Reply-To: <20060215051908.GF13033@snout>
On Wed, Feb 15, 2006 at 12:19:08AM -0500, Kyler Laird wrote:
> For changes to V4L2_CID_CONTRAST and V4L2_CID_SATURATION, the value is
> checked by "if (ctrl->value < 0 || ctrl->value > 127)" yet the maximum
> value in v4l2_queryctrl is set to 255 for both of these items. This
> means that programs (like MythTV) which set the contrast and saturation
> to the midvalue (127) get *full* contrast and saturation. (It's not
> pretty.)
>
> Setting the maximum values to 127 solves this problem.
Mauro, can you comment on this issue?
> Please copy me on responses.
>
> Thank you.
>
> --kyler
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next prev parent reply other threads:[~2006-03-08 21:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-15 5:19 drivers/media/video/saa7115.c misreports max. value of contrast and saturation Kyler Laird
2006-03-08 21:19 ` Adrian Bunk [this message]
2006-03-08 21:42 ` [v4l-dvb-maintainer] " Hans Verkuil
2006-03-08 22:47 ` Mauro Carvalho Chehab
2006-03-08 23:46 ` Adrian Bunk
2006-03-09 0:21 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060308211900.GM4006@stusta.de \
--to=bunk@stusta.de \
--cc=kyler-keyword-lkml00.e701c2@lairds.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=v4l-dvb-maintainer@linuxtv.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.