From: Jens Axboe <axboe@suse.de>
To: Tejun Heo <htejun@gmail.com>
Cc: Jeff Garzik <jgarzik@pobox.com>,
albertcc@tw.ibm.com, linux-ide@vger.kernel.org
Subject: Re: [PATCH] libata: increase LBA48 max sectors to 65535
Date: Wed, 15 Feb 2006 14:07:25 +0100 [thread overview]
Message-ID: <20060215130725.GP4203@suse.de> (raw)
In-Reply-To: <20060215072449.GA31691@htj.dyndns.org>
On Wed, Feb 15 2006, Tejun Heo wrote:
> max_hw_sectors/max_sectors separation patch made into the tree,
> increase max_sectors to its hardware limit.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
>
> ---
>
> Jeff, first of all, thanks for the pointer. I have two more
> questions.
>
> * I make ATA_MAX_SECTORS_LBA48 65535 (the 0000h case is supposed to be
> broken, right?); however, the comment says 65534. Should it be
> 65534?
Since we never noticed any breakage on !sectors on lba28, I think we can
safely assume that !sectors will work fine for lba48 as well. So why not
just make it full 64k, eg 65536? ->max_hw_sectors is an unsigned int
now, so 64k wont overflow it.
--
Jens Axboe
next prev parent reply other threads:[~2006-02-15 13:08 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-12 14:32 [PATCHSET] libata: make some configurations per-dev Tejun Heo
2006-02-12 14:32 ` [PATCH 2/4] libata: move cdb_len for host to device Tejun Heo
2006-02-12 14:32 ` [PATCH 1/4] libata: make ata_dev_knobble() per-device Tejun Heo
2006-02-12 19:29 ` Jeff Garzik
2006-02-12 14:32 ` [PATCH 3/4] libata: add per-device max_sectors Tejun Heo
2006-02-12 19:37 ` Jeff Garzik
2006-02-13 0:47 ` Tejun Heo
2006-02-13 4:58 ` Jeff Garzik
2006-02-15 7:24 ` [PATCH] libata: increase LBA48 max sectors to 65535 Tejun Heo
2006-02-15 13:07 ` Jens Axboe [this message]
2006-02-15 15:04 ` Tejun Heo
2006-02-15 15:12 ` Jens Axboe
2006-02-15 15:30 ` Tejun Heo
2006-02-15 19:03 ` Mark Lord
2006-02-15 20:21 ` Jeff Garzik
2006-02-15 23:05 ` Mark Lord
2006-02-20 11:23 ` Jeff Garzik
2006-02-20 13:54 ` Mark Lord
2006-02-20 13:58 ` Jens Axboe
2006-02-16 7:42 ` Jens Axboe
2006-02-20 11:25 ` Jeff Garzik
2006-02-20 11:44 ` Jens Axboe
2006-02-20 21:59 ` Jeff Garzik
2006-02-12 14:32 ` [PATCH 4/4] libata: kill sht->max_sectors Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060215130725.GP4203@suse.de \
--to=axboe@suse.de \
--cc=albertcc@tw.ibm.com \
--cc=htejun@gmail.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.