From: Tejun Heo <htejun@gmail.com>
To: Jens Axboe <axboe@suse.de>
Cc: Jeff Garzik <jgarzik@pobox.com>,
albertcc@tw.ibm.com, linux-ide@vger.kernel.org
Subject: Re: [PATCH] libata: increase LBA48 max sectors to 65535
Date: Thu, 16 Feb 2006 00:30:02 +0900 [thread overview]
Message-ID: <43F348FA.5070504@gmail.com> (raw)
In-Reply-To: <20060215151200.GW4203@suse.de>
Jens Axboe wrote:
> On Thu, Feb 16 2006, Tejun Heo wrote:
>>
>>libata currently sets max_sectors to 200 (ATA_MAX_SECTORS) on lba28.
>>Are you talking about IDE driver? IDE driver seems to set max_sectors
>>to 256 on probe and make it 2048 while setting up ide disk if lba48.
>
>
> Yes I mean the IDE driver. The 200 sector value in libata has always
> struck me as being extremely odd and a very bad choice. It's somewhere
> in between reasonable defaults, which isn't very nice. I'd suggest just
> making it 256 as well, unless Jeff has a reason why it's set to 200.
>
>
>>Hmmm... Can we really trust all the firmwares? I just feel that some
>>drive out there ought have screwed up about nsect == 00h/0000h case.
>
>
> Apparently Windows uses it, so I'd say that should pretty much guarantee
> that it will work for us. And as I mentioned, there has never been a
> case where the IDE driver value of 256 triggered a drive bug (one time
> one was suspected, it turned out to be something else though).
>
Well, then it's Jeff's call. Thanks for the explanation. :-)
--
tejun
next prev parent reply other threads:[~2006-02-15 15:32 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-12 14:32 [PATCHSET] libata: make some configurations per-dev Tejun Heo
2006-02-12 14:32 ` [PATCH 1/4] libata: make ata_dev_knobble() per-device Tejun Heo
2006-02-12 19:29 ` Jeff Garzik
2006-02-12 14:32 ` [PATCH 2/4] libata: move cdb_len for host to device Tejun Heo
2006-02-12 14:32 ` [PATCH 3/4] libata: add per-device max_sectors Tejun Heo
2006-02-12 19:37 ` Jeff Garzik
2006-02-13 0:47 ` Tejun Heo
2006-02-13 4:58 ` Jeff Garzik
2006-02-15 7:24 ` [PATCH] libata: increase LBA48 max sectors to 65535 Tejun Heo
2006-02-15 13:07 ` Jens Axboe
2006-02-15 15:04 ` Tejun Heo
2006-02-15 15:12 ` Jens Axboe
2006-02-15 15:30 ` Tejun Heo [this message]
2006-02-15 19:03 ` Mark Lord
2006-02-15 20:21 ` Jeff Garzik
2006-02-15 23:05 ` Mark Lord
2006-02-20 11:23 ` Jeff Garzik
2006-02-20 13:54 ` Mark Lord
2006-02-20 13:58 ` Jens Axboe
2006-02-16 7:42 ` Jens Axboe
2006-02-20 11:25 ` Jeff Garzik
2006-02-20 11:44 ` Jens Axboe
2006-02-20 21:59 ` Jeff Garzik
2006-02-12 14:32 ` [PATCH 4/4] libata: kill sht->max_sectors Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43F348FA.5070504@gmail.com \
--to=htejun@gmail.com \
--cc=albertcc@tw.ibm.com \
--cc=axboe@suse.de \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.