Re: [Qemu-devel] [PATCH] Trivial code improvement

[Daniel Jacobowitz <drow@false.org>]

On Thu, Feb 16, 2006 at 04:32:04PM +0000, Thiemo Seufer wrote:
> Index: cpu-exec.c
> ===================================================================
> RCS file: /sources/qemu/qemu/cpu-exec.c,v
> retrieving revision 1.73
> diff -u -p -r1.73 cpu-exec.c
> --- cpu-exec.c	8 Feb 2006 22:43:39 -0000	1.73
> +++ cpu-exec.c	16 Feb 2006 15:21:03 -0000
> @@ -549,7 +549,7 @@ int cpu_exec(CPUState *env1)
>                          do_interrupt(env);
>                      }
>  #endif
> -                    if (env->interrupt_request & CPU_INTERRUPT_EXITTB) {
> +                    if (interrupt_request & CPU_INTERRUPT_EXITTB) {
>                          env->interrupt_request &= ~CPU_INTERRUPT_EXITTB;
>                          /* ensure that no TB jump will be modified as
>                             the program flow was changed */

Didn't we go round this recently?  do_interrupt might modify
env->interrupt_request - see target-arm/helper.c for instance.

-- 
Daniel Jacobowitz
CodeSourcery