From: Andi Kleen <ak@suse.de>
To: Dave Hansen <haveblue@us.ibm.com>
Cc: Yasunori Goto <y-goto@jp.fujitsu.com>,
Andrew Morton <akpm@osdl.org>, "Luck, Tony" <tony.luck@intel.com>,
"Tolentino, Matthew E" <matthew.e.tolentino@intel.com>,
Joel Schopp <jschopp@austin.ibm.com>,
linux-ia64@vger.kernel.org,
Linux Kernel ML <linux-kernel@vger.kernel.org>,
x86-64 Discuss <discuss@x86-64.org>
Subject: Re: [PATCH: 001/012] Memory hotplug for new nodes v.2. (pgdat allocation)
Date: Fri, 17 Feb 2006 16:16:33 +0000 [thread overview]
Message-ID: <200602171716.34297.ak@suse.de> (raw)
In-Reply-To: <1140190792.21383.64.camel@localhost.localdomain>
On Friday 17 February 2006 16:39, Dave Hansen wrote:
> I'm a teensy bit concerned that this doesn't share enough code with the
> boot-time initialization. For instance, the kthread_create() seems to
> be a pretty darn generic piece. I'd feel a lot more at ease if this
> patch did something with _existing_ code instead of just adding.
Agreed. Having significantly different code paths for hot add and
for normal initialization isn't a good idea. It will just lead to
long term code drift and problems.
So i would suggest to generalize the standard functions enough
to make them callable from a hotplug layer.
-Andi
WARNING: multiple messages have this Message-ID (diff)
From: Andi Kleen <ak@suse.de>
To: Dave Hansen <haveblue@us.ibm.com>
Cc: Yasunori Goto <y-goto@jp.fujitsu.com>,
Andrew Morton <akpm@osdl.org>, "Luck, Tony" <tony.luck@intel.com>,
"Tolentino, Matthew E" <matthew.e.tolentino@intel.com>,
Joel Schopp <jschopp@austin.ibm.com>,
linux-ia64@vger.kernel.org,
Linux Kernel ML <linux-kernel@vger.kernel.org>,
x86-64 Discuss <discuss@x86-64.org>
Subject: Re: [PATCH: 001/012] Memory hotplug for new nodes v.2. (pgdat allocation)
Date: Fri, 17 Feb 2006 17:16:33 +0100 [thread overview]
Message-ID: <200602171716.34297.ak@suse.de> (raw)
In-Reply-To: <1140190792.21383.64.camel@localhost.localdomain>
On Friday 17 February 2006 16:39, Dave Hansen wrote:
> I'm a teensy bit concerned that this doesn't share enough code with the
> boot-time initialization. For instance, the kthread_create() seems to
> be a pretty darn generic piece. I'd feel a lot more at ease if this
> patch did something with _existing_ code instead of just adding.
Agreed. Having significantly different code paths for hot add and
for normal initialization isn't a good idea. It will just lead to
long term code drift and problems.
So i would suggest to generalize the standard functions enough
to make them callable from a hotplug layer.
-Andi
next prev parent reply other threads:[~2006-02-17 16:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-17 13:28 [PATCH: 001/012] Memory hotplug for new nodes v.2. (pgdat allocation) Yasunori Goto
2006-02-17 13:28 ` Yasunori Goto
2006-02-17 15:39 ` [PATCH: 001/012] Memory hotplug for new nodes v.2. (pgdat Dave Hansen
2006-02-17 15:39 ` [PATCH: 001/012] Memory hotplug for new nodes v.2. (pgdat allocation) Dave Hansen
2006-02-17 16:16 ` Andi Kleen [this message]
2006-02-17 16:16 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200602171716.34297.ak@suse.de \
--to=ak@suse.de \
--cc=akpm@osdl.org \
--cc=discuss@x86-64.org \
--cc=haveblue@us.ibm.com \
--cc=jschopp@austin.ibm.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.e.tolentino@intel.com \
--cc=tony.luck@intel.com \
--cc=y-goto@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.