* [patch] au1xmmc: fix mmc_rsp_type typo
@ 2006-02-21 9:38 Domen Puncer
2006-02-21 10:46 ` Domen Puncer
0 siblings, 1 reply; 4+ messages in thread
From: Domen Puncer @ 2006-02-21 9:38 UTC (permalink / raw)
To: ralf; +Cc: linux-mips
Patch that added this suggests mmc_rsp_type should be mmc_resp_type.
Signed-off-by: Domen Puncer <domen.puncer@ultra.si>
drivers/mmc/au1xmmc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux-2.6.16-rc4.git/drivers/mmc/au1xmmc.c
===================================================================
--- linux-2.6.16-rc4.git.orig/drivers/mmc/au1xmmc.c
+++ linux-2.6.16-rc4.git/drivers/mmc/au1xmmc.c
@@ -195,7 +195,7 @@ static int au1xmmc_send_command(struct a
u32 mmccmd = (cmd->opcode << SD_CMD_CI_SHIFT);
- switch (mmc_rsp_type(cmd->flags)) {
+ switch (mmc_resp_type(cmd->flags)) {
case MMC_RSP_R1:
mmccmd |= SD_CMD_RT_1;
break;
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [patch] au1xmmc: fix mmc_rsp_type typo
2006-02-21 9:38 [patch] au1xmmc: fix mmc_rsp_type typo Domen Puncer
@ 2006-02-21 10:46 ` Domen Puncer
2006-02-21 12:34 ` Ralf Baechle
0 siblings, 1 reply; 4+ messages in thread
From: Domen Puncer @ 2006-02-21 10:46 UTC (permalink / raw)
To: ralf; +Cc: linux-mips
On 21/02/06 10:38 +0100, Domen Puncer wrote:
> Patch that added this suggests mmc_rsp_type should be mmc_resp_type.
Ouch, I thought I compile tested.
Here's a fixed version:
There's no mmc_rsp_type
Signed-off-by: Domen Puncer <domen.puncer@ultra.si>
Index: linux-2.6.16-rc4.git/drivers/mmc/au1xmmc.c
===================================================================
--- linux-2.6.16-rc4.git.orig/drivers/mmc/au1xmmc.c
+++ linux-2.6.16-rc4.git/drivers/mmc/au1xmmc.c
@@ -41,6 +41,7 @@
#include <linux/mm.h>
#include <linux/interrupt.h>
#include <linux/dma-mapping.h>
+#include <linux/platform_device.h>
#include <linux/mmc/host.h>
#include <linux/mmc/protocol.h>
@@ -195,7 +195,7 @@ static int au1xmmc_send_command(struct a
u32 mmccmd = (cmd->opcode << SD_CMD_CI_SHIFT);
- switch (mmc_rsp_type(cmd->flags)) {
+ switch (mmc_resp_type(cmd)) {
case MMC_RSP_R1:
mmccmd |= SD_CMD_RT_1;
break;
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [patch] au1xmmc: fix mmc_rsp_type typo
2006-02-21 10:46 ` Domen Puncer
@ 2006-02-21 12:34 ` Ralf Baechle
2006-02-21 15:19 ` Jordan Crouse
0 siblings, 1 reply; 4+ messages in thread
From: Ralf Baechle @ 2006-02-21 12:34 UTC (permalink / raw)
To: Domen Puncer; +Cc: Jordan Crouse, linux-mips
On Tue, Feb 21, 2006 at 11:46:19AM +0100, Domen Puncer wrote:
> > Patch that added this suggests mmc_rsp_type should be mmc_resp_type.
>
> Ouch, I thought I compile tested.
> Here's a fixed version:
Jordan?
Ralf
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: au1xmmc: fix mmc_rsp_type typo
2006-02-21 12:34 ` Ralf Baechle
@ 2006-02-21 15:19 ` Jordan Crouse
0 siblings, 0 replies; 4+ messages in thread
From: Jordan Crouse @ 2006-02-21 15:19 UTC (permalink / raw)
To: Ralf Baechle; +Cc: Domen Puncer, linux-mips
> > > Patch that added this suggests mmc_rsp_type should be mmc_resp_type.
> >
> > Ouch, I thought I compile tested.
> > Here's a fixed version:
>
> Jordan?
Looks good to me. Thanks Domen.
Jordan
--
Jordan Crouse
Senior Linux Engineer
AMD - Personal Connectivity Solutions Group
<www.amd.com/embeddedprocessors>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2006-02-21 15:05 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-02-21 9:38 [patch] au1xmmc: fix mmc_rsp_type typo Domen Puncer
2006-02-21 10:46 ` Domen Puncer
2006-02-21 12:34 ` Ralf Baechle
2006-02-21 15:19 ` Jordan Crouse
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.