All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Gibson <david@gibson.dropbear.id.au>
To: David Mosberger-Tang <David.Mosberger@acm.org>
Cc: "Chen, Kenneth W" <kenneth.w.chen@intel.com>,
	linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: IA64 non-contiguous memory space bugs
Date: Wed, 22 Feb 2006 04:02:50 +0000	[thread overview]
Message-ID: <20060222040250.GA3081@localhost.localdomain> (raw)
In-Reply-To: <ed5aea430602211955k225698c9w35ac02eae071a0c5@mail.gmail.com>

On Tue, Feb 21, 2006 at 08:55:15PM -0700, David Mosberger-Tang wrote:
> I'm only following this superficially, but keep in mind that a vm-area
> MUST NEVER cross a hole.

Yes.. but it can, that's precisely the bug.

> On 2/21/06, Chen, Kenneth W <kenneth.w.chen@intel.com> wrote:
> > David Gibson wrote on Tuesday, February 21, 2006 4:14 PM
> > > First bug (confirmed many months ago by Chris Wedgwood) - you can get
> > > weird effects if you attempt to mmap() something into one of the
> > > address space gaps.  The ia64 outer wrapper for mmap2() tries to
> > > prevent it, but doesn't do a good enough job, it's still possible
> > > indirectly with shmat() and maybe mremap().  Basic trouble is that
> > > most of the checks applied by the generic code assume that everything
> > > between 0 and TASK_SIZE is valid.
> >
> > Ha ha ha.
> >
> > On ia64, the low level tlb fault handler (vhpt_miss and nested_dtlb_miss)
> > checks that all unused address bits (between REGION_NUMBER and PGDIR_SHIFT)
> > should be all zero.  If they are not zero, it will fall into page fault
> > handler and in there, ia64 should just send SEGV instead of happily hand
> > over a page.  Buggy buggy....

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

WARNING: multiple messages have this Message-ID (diff)
From: David Gibson <david@gibson.dropbear.id.au>
To: David Mosberger-Tang <David.Mosberger@acm.org>
Cc: "Chen, Kenneth W" <kenneth.w.chen@intel.com>,
	linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: IA64 non-contiguous memory space bugs
Date: Wed, 22 Feb 2006 15:02:50 +1100	[thread overview]
Message-ID: <20060222040250.GA3081@localhost.localdomain> (raw)
In-Reply-To: <ed5aea430602211955k225698c9w35ac02eae071a0c5@mail.gmail.com>

On Tue, Feb 21, 2006 at 08:55:15PM -0700, David Mosberger-Tang wrote:
> I'm only following this superficially, but keep in mind that a vm-area
> MUST NEVER cross a hole.

Yes.. but it can, that's precisely the bug.

> On 2/21/06, Chen, Kenneth W <kenneth.w.chen@intel.com> wrote:
> > David Gibson wrote on Tuesday, February 21, 2006 4:14 PM
> > > First bug (confirmed many months ago by Chris Wedgwood) - you can get
> > > weird effects if you attempt to mmap() something into one of the
> > > address space gaps.  The ia64 outer wrapper for mmap2() tries to
> > > prevent it, but doesn't do a good enough job, it's still possible
> > > indirectly with shmat() and maybe mremap().  Basic trouble is that
> > > most of the checks applied by the generic code assume that everything
> > > between 0 and TASK_SIZE is valid.
> >
> > Ha ha ha.
> >
> > On ia64, the low level tlb fault handler (vhpt_miss and nested_dtlb_miss)
> > checks that all unused address bits (between REGION_NUMBER and PGDIR_SHIFT)
> > should be all zero.  If they are not zero, it will fall into page fault
> > handler and in there, ia64 should just send SEGV instead of happily hand
> > over a page.  Buggy buggy....

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

  reply	other threads:[~2006-02-22  4:02 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-22  0:13 IA64 non-contiguous memory space bugs David Gibson
2006-02-22  0:13 ` David Gibson
2006-02-22  0:39 ` David S. Miller
2006-02-22  0:39   ` David S. Miller
2006-02-22  2:17   ` David Gibson
2006-02-22  2:17     ` David Gibson
2006-02-22  1:31 ` Chen, Kenneth W
2006-02-22  1:31   ` Chen, Kenneth W
2006-02-22  2:15   ` 'David Gibson'
2006-02-22  2:15     ` 'David Gibson'
2006-02-22  1:51 ` Chen, Kenneth W
2006-02-22  1:51   ` Chen, Kenneth W
2006-02-22  2:25   ` 'David Gibson'
2006-02-22  2:25     ` 'David Gibson'
2006-02-22 16:35     ` Hugh Dickins
2006-02-22 16:35       ` Hugh Dickins
2006-02-22 23:49       ` 'David Gibson'
2006-02-22 23:49         ` 'David Gibson'
2006-02-23 20:13         ` Hugh Dickins
2006-02-23 20:13           ` Hugh Dickins
2006-02-24  0:11           ` 'David Gibson'
2006-02-24  0:11             ` 'David Gibson'
2006-02-22  2:45 ` Chen, Kenneth W
2006-02-22  2:45   ` Chen, Kenneth W
2006-02-22  2:53 ` Chen, Kenneth W
2006-02-22  2:53   ` Chen, Kenneth W
2006-02-22  3:55   ` David Mosberger-Tang
2006-02-22  3:55     ` David Mosberger-Tang
2006-02-22  4:02     ` David Gibson [this message]
2006-02-22  4:02       ` David Gibson
2006-02-22  3:01 ` Zhang, Yanmin
2006-02-22  3:01   ` Zhang, Yanmin
2006-02-22 16:19 ` Chen, Kenneth W
2006-02-22 16:19   ` Chen, Kenneth W
2006-02-22 23:26   ` 'David Gibson'
2006-02-22 23:26     ` 'David Gibson'
2006-02-24  1:14 ` Chen, Kenneth W
2006-02-24  1:14   ` Chen, Kenneth W
2006-02-24  2:46   ` 'David Gibson'
2006-02-24  2:46     ` 'David Gibson'

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060222040250.GA3081@localhost.localdomain \
    --to=david@gibson.dropbear.id.au \
    --cc=David.Mosberger@acm.org \
    --cc=kenneth.w.chen@intel.com \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.