From: Tim Cooijmans <tim@aapopfiets.nl>
To: kernel-janitors@vger.kernel.org
Subject: [KJ] [PATCH] check request_region return value
Date: Fri, 24 Feb 2006 21:49:22 +0000 [thread overview]
Message-ID: <200602242249.22568.tim@aapopfiets.nl> (raw)
From: Tim Cooijmans <tim@aapopfiets.nl>
Check request_region return value in arch/powerpc/platform/chrp/setup.c.
Passed compilation.
Signed-off-by: Tim Cooijmans <tim@aapopfiets.nl>
---
--- linux-2.6.16-rc4-orig/arch/powerpc/platforms/chrp/setup.c 2006-02-21
20:18:41.000000000 +0100
+++ linux-2.6.16-rc4/arch/powerpc/platforms/chrp/setup.c 2006-02-24
18:30:10.000000000 +0100
@@ -471,15 +471,54 @@ chrp_init2(void)
chrp_nvram_init();
#endif
- request_region(0x20,0x20,"pic1");
- request_region(0xa0,0x20,"pic2");
- request_region(0x00,0x20,"dma1");
- request_region(0x40,0x20,"timer");
- request_region(0x80,0x10,"dma page reg");
- request_region(0xc0,0x20,"dma2");
+ if (request_region(0x20,0x20,"pic1") = NULL) {
+ printk(KERN_WARNING "chrp_init2: could not "
+ "allocate pic1 region\n");
+ goto out_pic1;
+ }
+ if (request_region(0xa0,0x20,"pic2") = NULL) {
+ printk(KERN_WARNING "chrp_init2: could not "
+ "allocate pic2 region\n");
+ goto out_pic2;
+ }
+ if (request_region(0x00,0x20,"dma1") = NULL) {
+ printk(KERN_WARNING "chrp_init2: could not "
+ "allocate dma1 region\n");
+ goto out_dma1;
+ }
+ if (request_region(0x40,0x20,"timer") = NULL) {
+ printk(KERN_WARNING "chrp_init2: could not "
+ "allocate timer region\n");
+ goto out_timer;
+ }
+ if (request_region(0x80,0x10,"dma page reg") = NULL) {
+ printk(KERN_WARNING "chrp_init2: could not "
+ "allocate dma page reg region\n");
+ goto out_dma_page_reg;
+ }
+ if (request_region(0xc0,0x20,"dma2") = NULL) {
+ printk(KERN_WARNING "chrp_init2: could not "
+ "allocate dma2 region\n");
+ goto out_dma2;
+ }
if (ppc_md.progress)
ppc_md.progress(" Have fun! ", 0x7777);
+
+ return;
+
+out_dma2:
+ release_region(0x80,0x10);
+out_dma_page_reg:
+ release_region(0x40,0x20);
+out_timer:
+ release_region(0x00,0x20);
+out_dma1:
+ release_region(0xa0,0x20);
+out_pic2:
+ release_region(0x20,0x20);
+out_pic1:
+ return;
}
void __init chrp_init(void)
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
next reply other threads:[~2006-02-24 21:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-24 21:49 Tim Cooijmans [this message]
2006-02-24 21:58 ` [KJ] [PATCH] check request_region return value Jesper Juhl
2006-02-24 23:07 ` Tim Cooijmans
2006-02-24 23:11 ` Jesper Juhl
2006-02-25 13:58 ` Tim Cooijmans
2006-02-25 14:13 ` Jesper Juhl
2006-02-25 17:26 ` Tim Cooijmans
2006-02-25 17:34 ` Jesper Juhl
2006-02-25 20:42 ` Tim Cooijmans
2006-02-25 21:03 ` Jesper Juhl
2006-02-26 4:50 ` Darren Jenkins\
2006-02-26 19:52 ` Tim Cooijmans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200602242249.22568.tim@aapopfiets.nl \
--to=tim@aapopfiets.nl \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.