From: Tim Cooijmans <tim@aapopfiets.nl>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] [PATCH] check request_region return value
Date: Fri, 24 Feb 2006 23:07:15 +0000 [thread overview]
Message-ID: <200602250007.15708.tim@aapopfiets.nl> (raw)
In-Reply-To: <200602242249.22568.tim@aapopfiets.nl>
On Friday 24 February 2006 22:58, Jesper Juhl wrote:
> On 2/24/06, Tim Cooijmans <tim@aapopfiets.nl> wrote:
> > From: Tim Cooijmans <tim@aapopfiets.nl>
> >
> > Check request_region return value in arch/powerpc/platform/chrp/setup.c.
> > Passed compilation.
>
> Looks OK to me, but couldn't this be improved by changing the function
> to return an int stating if things are OK or not and then having
> caller check the return value and act appropriately?
Yes, I thought about that. The reason I didn't do this is that chrp_init2 is
assigned to ppc_md.init. ppc_md is a struct machdep_calls, which seems to be
an abstraction of machine-dependent stuff. Changing the return type is
probably going to break lots of things.
Anyway, warning when things fail is better than nothing.
Tim
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
next prev parent reply other threads:[~2006-02-24 23:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-24 21:49 [KJ] [PATCH] check request_region return value Tim Cooijmans
2006-02-24 21:58 ` Jesper Juhl
2006-02-24 23:07 ` Tim Cooijmans [this message]
2006-02-24 23:11 ` Jesper Juhl
2006-02-25 13:58 ` Tim Cooijmans
2006-02-25 14:13 ` Jesper Juhl
2006-02-25 17:26 ` Tim Cooijmans
2006-02-25 17:34 ` Jesper Juhl
2006-02-25 20:42 ` Tim Cooijmans
2006-02-25 21:03 ` Jesper Juhl
2006-02-26 4:50 ` Darren Jenkins\
2006-02-26 19:52 ` Tim Cooijmans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200602250007.15708.tim@aapopfiets.nl \
--to=tim@aapopfiets.nl \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.