fix build breakage in eeh.c in 2.6.16-rc5-git5

fix build breakage in eeh.c in 2.6.16-rc5-git5

[Greg KH]

This patch should fixe a problem with eeh_add_device_late() not being
defined in the ppc64 build process, causing the build to break.

Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

---
 include/asm-powerpc/eeh.h |    1 +
 1 files changed, 1 insertion(+)

--- linux-2.6.15.orig/include/asm-powerpc/eeh.h	2006-03-01 11:30:19.000000000 -0800
+++ linux-2.6.15/include/asm-powerpc/eeh.h	2006-03-01 12:04:25.000000000 -0800
@@ -61,6 +61,7 @@
  * to finish the eeh setup for this device.
  */
 void eeh_add_device_early(struct device_node *);
+void eeh_add_device_late(struct pci_dev *dev);
 void eeh_add_device_tree_early(struct device_node *);
 void eeh_add_device_tree_late(struct pci_bus *);
 

Re: fix build breakage in eeh.c in 2.6.16-rc5-git5

[Paul Mackerras]

Greg KH writes:

> This patch should fixe a problem with eeh_add_device_late() not being
> defined in the ppc64 build process, causing the build to break.

John Rose just sent a patch making eeh_add_device_late static and
moving it to be defined before it is called in
arch/powerpc/platforms/pseries/eeh.c.

Since he maintains this stuff, I'm more inclined to take his patch.

Paul.

Re: fix build breakage in eeh.c in 2.6.16-rc5-git5

[Greg KH]

On Thu, Mar 02, 2006 at 08:54:56AM +1100, Paul Mackerras wrote:
> Greg KH writes:
> 
> > This patch should fixe a problem with eeh_add_device_late() not being
> > defined in the ppc64 build process, causing the build to break.
> 
> John Rose just sent a patch making eeh_add_device_late static and
> moving it to be defined before it is called in
> arch/powerpc/platforms/pseries/eeh.c.
> 
> Since he maintains this stuff, I'm more inclined to take his patch.

That's fine with me, as long as it makes it into 2.6.16-final :)

thanks,

greg k-h

Re: fix build breakage in eeh.c in 2.6.16-rc5-git5

[Greg KH]

On Wed, Mar 01, 2006 at 02:03:28PM -0800, Greg KH wrote:
> On Thu, Mar 02, 2006 at 08:54:56AM +1100, Paul Mackerras wrote:
> > Greg KH writes:
> > 
> > > This patch should fixe a problem with eeh_add_device_late() not being
> > > defined in the ppc64 build process, causing the build to break.
> > 
> > John Rose just sent a patch making eeh_add_device_late static and
> > moving it to be defined before it is called in
> > arch/powerpc/platforms/pseries/eeh.c.
> > 
> > Since he maintains this stuff, I'm more inclined to take his patch.
> 
> That's fine with me, as long as it makes it into 2.6.16-final :)

Hm, looks like my fix made it into Linus's tree, so you might want to
send him the "correct" way to do this against that.

thanks,

greg k-h