From: Jan Blunck <jblunck@suse.de>
To: Kirill Korotaev <dev@sw.ru>
Cc: Neil Brown <neilb@suse.de>, Kirill Korotaev <dev@openvz.org>,
akpm@osdl.org, viro@zeniv.linux.org.uk, olh@suse.de,
bsingharora@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix shrink_dcache_parent() against shrink_dcache_memory() race (3rd updated patch)]
Date: Fri, 10 Mar 2006 11:59:50 +0100 [thread overview]
Message-ID: <20060310105950.GL4243@hasse.suse.de> (raw)
In-Reply-To: <441138B7.9060809@sw.ru>
On Fri, Mar 10, Kirill Korotaev wrote:
> >I really think that we need to stop prune_one_dentry from being called
> >on dentries for a filesystem that is being unmounted. With that code
> >currently in -git, that means passing a 'struct super_block *' into
> >prune_dcache so that it ignores any filesystem with ->s_root==NULL
> >unless that filesystem is the filesystem that was passed.
> Can try...
>
Can not ... because of down_read(s_umount) before checking s_root :(
So what do we do now?
1. always get the reference counting right outside of dcache_lock
2. hack around with different paths for prune_dcache() when called from
shrink_dcache_memory() and shrink_dcache_parent()
I think that we should go for the first.
Regards,
Jan
--
Jan Blunck jblunck@suse.de
SuSE LINUX AG - A Novell company
Maxfeldstr. 5 +49-911-74053-608
D-90409 Nürnberg http://www.suse.de
next prev parent reply other threads:[~2006-03-10 10:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-09 16:58 [PATCH] Fix shrink_dcache_parent() against shrink_dcache_memory() race (3rd updated patch)] Jan Blunck
2006-03-09 17:07 ` Kirill Korotaev
2006-03-10 5:09 ` Neil Brown
2006-03-10 8:28 ` Kirill Korotaev
2006-03-10 10:59 ` Jan Blunck [this message]
2006-03-10 11:23 ` Kirill Korotaev
2006-03-10 11:56 ` Neil Brown
2006-03-10 12:02 ` Jan Blunck
2006-03-10 12:19 ` Kirill Korotaev
2006-03-10 11:51 ` Neil Brown
2006-03-10 12:31 ` Jan Blunck
2006-03-10 17:17 ` Balbir Singh
2006-03-12 21:57 ` Neil Brown
2006-03-12 23:03 ` Jan Blunck
2006-03-13 5:45 ` Neil Brown
2006-03-13 15:52 ` Balbir Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060310105950.GL4243@hasse.suse.de \
--to=jblunck@suse.de \
--cc=akpm@osdl.org \
--cc=bsingharora@gmail.com \
--cc=dev@openvz.org \
--cc=dev@sw.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@suse.de \
--cc=olh@suse.de \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.