From: Kirill Korotaev <dev@sw.ru>
To: Jan Blunck <jblunck@suse.de>
Cc: Neil Brown <neilb@suse.de>, Kirill Korotaev <dev@openvz.org>,
akpm@osdl.org, viro@zeniv.linux.org.uk, olh@suse.de,
bsingharora@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix shrink_dcache_parent() against shrink_dcache_memory() race (3rd updated patch)]
Date: Fri, 10 Mar 2006 15:19:41 +0300 [thread overview]
Message-ID: <44116EDD.8020903@sw.ru> (raw)
In-Reply-To: <20060310120232.GM4243@hasse.suse.de>
>>>I think that we should go for the first.
>>
>>just an idea which came to my mind:
>>can't we fix it the following way:
>>1. fix select_parent() when called from generic_shutdown_super() to loop
>>until _all_ dentries are shrinked (not only those, with d_count = 1);
>>this guarentees that no dentries are left.
>>2. no dentries are left, but iput() can be in progress.
>>So can't we simply make invalidate_inodes() to be in a loop with
>>schedule() until no busy inodes are left?!
>
>
> But this hides the places where dput() is called after mntput() and locks up
> when somebody forgets to call dput() at all. And I think we should printk() in
> that situations instead of waiting for them.
I think both: printk and wait.
From my own personal experience with it: it is better to wait in a loop
and be able to collect information, then to crash.
Thanks,
Kirill
next prev parent reply other threads:[~2006-03-10 12:15 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-09 16:58 [PATCH] Fix shrink_dcache_parent() against shrink_dcache_memory() race (3rd updated patch)] Jan Blunck
2006-03-09 17:07 ` Kirill Korotaev
2006-03-10 5:09 ` Neil Brown
2006-03-10 8:28 ` Kirill Korotaev
2006-03-10 10:59 ` Jan Blunck
2006-03-10 11:23 ` Kirill Korotaev
2006-03-10 11:56 ` Neil Brown
2006-03-10 12:02 ` Jan Blunck
2006-03-10 12:19 ` Kirill Korotaev [this message]
2006-03-10 11:51 ` Neil Brown
2006-03-10 12:31 ` Jan Blunck
2006-03-10 17:17 ` Balbir Singh
2006-03-12 21:57 ` Neil Brown
2006-03-12 23:03 ` Jan Blunck
2006-03-13 5:45 ` Neil Brown
2006-03-13 15:52 ` Balbir Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44116EDD.8020903@sw.ru \
--to=dev@sw.ru \
--cc=akpm@osdl.org \
--cc=bsingharora@gmail.com \
--cc=dev@openvz.org \
--cc=jblunck@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@suse.de \
--cc=olh@suse.de \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.