* [2.6 patch] md/bitmap.c:bitmap_mask_state(): fix inconsequent NULL checking
@ 2006-03-10 18:06 Adrian Bunk
0 siblings, 0 replies; only message in thread
From: Adrian Bunk @ 2006-03-10 18:06 UTC (permalink / raw)
To: dm-devel; +Cc: linux-kernel
We dereference bitmap both one line above and one line below this check
rendering this check quite useless.
Spotted by the Coverity checker.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.16-rc5-mm3-full/drivers/md/bitmap.c.old 2006-03-10 19:02:38.000000000 +0100
+++ linux-2.6.16-rc5-mm3-full/drivers/md/bitmap.c 2006-03-10 19:02:54.000000000 +0100
@@ -546,7 +546,7 @@ static void bitmap_mask_state(struct bit
unsigned long flags;
spin_lock_irqsave(&bitmap->lock, flags);
- if (!bitmap || !bitmap->sb_page) { /* can't set the state */
+ if (!bitmap->sb_page) { /* can't set the state */
spin_unlock_irqrestore(&bitmap->lock, flags);
return;
}
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2006-03-10 18:06 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-03-10 18:06 [2.6 patch] md/bitmap.c:bitmap_mask_state(): fix inconsequent NULL checking Adrian Bunk
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.